Skip to content

Fix pyright typing for replay export tests and guard meta access#139

Merged
AlexanderOnischenko merged 1 commit intofeature/tracerfrom
codex/fix-attribute-access-errors-in-tests
Feb 1, 2026
Merged

Fix pyright typing for replay export tests and guard meta access#139
AlexanderOnischenko merged 1 commit intofeature/tracerfrom
codex/fix-attribute-access-errors-in-tests

Conversation

@AlexanderOnischenko
Copy link
Owner

Motivation

  • Address Pyright/type-checker errors about untyped capsys/caplog fixtures and an optional member access on replay event meta reported in src/fetchgraph/replay/export.py and test files.

Description

  • Add explicit pytest fixture typing imports and annotations using CaptureFixture[str] and LogCaptureFixture in the replay export tests to satisfy static typing.
  • Protect metadata access in format_replay_case_matches by normalizing meta = event.get("meta") to an empty dict when it's not a dict, avoiding optional member access on None.

Testing

  • No automated tests were run as part of this change.

Codex Task

@AlexanderOnischenko AlexanderOnischenko merged commit 22b3513 into feature/tracer Feb 1, 2026
@AlexanderOnischenko AlexanderOnischenko deleted the codex/fix-attribute-access-errors-in-tests branch February 1, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant