addeditdate doesn't do what it says#32
Merged
Alexia merged 1 commit intoAlexia:masterfrom Mar 5, 2018
Merged
Conversation
Owner
|
Looks good to me! Looking through the Article.php class code it looks like it was relying on an older feature in an old version of MediaWiki to work. It has support in there for the newer MediaWiki versions, but as you said it was not selecting it from the database. Looks like order direction still is not working correctly, but I will merge this then fix that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the following query, %DATE% won't contain an article's edit date, even though
addeditdate=trueandordermethod=lasteditare part of the query. With this patch, addeditdate acts as one would expect. I'm not sure how addeditdate ever worked so there's a chance that this is just a misunderstanding on my part.edit: all of this happens on master as of 3.1.0.