Refactor device ID calculation in calcDeviceID function#730
Closed
skrashevich wants to merge 1 commit into
Closed
Conversation
… a MAC address with locally administered and unicast bits set using every second byte from the SHA512 hash of the seed. Update the unit tests accordingly
Owner
|
Why we needs this? Just for fun? Any changes to deviceid will break all current homekit setups. |
Collaborator
Author
it will not break current setups because of |
Collaborator
Author
Incorrect mac addresses (for example, from the multicast range) will cause difficult-diagnosable and hard-reproducible errors in some network environments |
Owner
|
This will break setup for all users who not set device_id in yaml or used short device_id. This is just device_id. I think it shouldn't be correct MAC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... to generate a MAC address with locally administered and unicast bits set using every second byte from the SHA512 hash of the seed