[ACS-10421] Add support for legacy config.json based approach for saved-searches (#4863)

* [ACS-9166]: introduces saved searches context service

* [ACS-9166]: migrates to context service

* [ACS-9166]: fixes tests

* [ACS-9166]: removes prev approach artifacts

* [ACS-9166]: fixes falsy emissions form pipe

* [ACS-9166]: adds reactive strategy option

* [ACS-9166]: tests fixes

* [ACS-9166]: minor fix

Author: rmnvch

docs/extending/rules-list.md

@@ -82,6 +82,6 @@ Rules/Evaluators created for specific features in ADW to be checked if supported
 
 | Version | Key                             | Description                                                               |
 |---------|---------------------------------|---------------------------------------------------------------------------|
-| 8.1.0   | isSavedSearchAvailable          | Checks whether current ACS version supports PUT method in Preferences API |
+| 8.1.0   | isPreferencesApiAvailable       | Checks whether current ACS version supports PUT method in Preferences API |
 | 8.1.0   | isFolderInfoAvailable           | Checks whether current ACS version supports folder size calculation API   |
 | 8.1.0   | isBulkActionsAvailable          | Checks whether current ACS version supports bulk update feature           |

projects/aca-content/assets/app.extensions.json

@@ -219,10 +219,7 @@
         "items": [
           {
             "id": "app.search.navbar",
-            "component": "app.search.navbar",
-            "rules": {
-              "visible": "isSavedSearchAvailable"
-            }
+            "component": "app.search.navbar"
           }
         ]
       }

projects/aca-content/src/lib/aca-content.module.ts

@@ -69,6 +69,7 @@ import { SearchResultsRowComponent } from './components/search/search-results-ro
 import { BulkActionsDropdownComponent } from './components/bulk-actions-dropdown/bulk-actions-dropdown.component';
 import { AgentsButtonComponent } from './components/knowledge-retrieval/search-ai/agents-button/agents-button.component';
 import { SaveSearchSidenavComponent } from './components/search/search-save/sidenav/save-search-sidenav.component';
+import { IsFeatureSupportedInCurrentAcsPipe } from './pipes/is-feature-supported.pipe';
 
 @NgModule({
   imports: [ContentModule.forRoot(), AppStoreModule, HammerModule],
@@ -134,7 +135,7 @@ import { SaveSearchSidenavComponent } from './components/search/search-save/side
         isSmartFolder: rules.isSmartFolder,
         isMultiSelection: rules.isMultiselection,
         canPrintFile: rules.canPrintFile,
-        isSavedSearchAvailable: rules.isSavedSearchAvailable,
+        isPreferencesApiAvailable: rules.isPreferencesApiAvailable,
         isFolderInfoAvailable: rules.isFolderInfoAvailable,
         isBulkActionsAvailable: rules.isBulkActionsAvailable,
 
@@ -169,7 +170,8 @@ import { SaveSearchSidenavComponent } from './components/search/search-save/side
         'app.areCategoriesEnabled': rules.areCategoriesEnabled,
         'app.isSSOEnabled': rules.isSSOEnabled
       }
-    })
+    }),
+    IsFeatureSupportedInCurrentAcsPipe
   ]
 })
 export class ContentServiceExtensionModule {}

projects/aca-content/src/lib/components/search/search-results/search-results.component.html

@@ -26,7 +26,6 @@
               <div class="aca-content__advanced-filters--header">
                 <p>{{ 'APP.BROWSE.SEARCH.ADVANCED_FILTERS' | translate }}</p>
                 <div class="aca-content__advanced-filters--header--action-buttons">
-                  @if('isSavedSearchAvailable' | isFeatureSupportedInCurrentAcs | async) {
                     <button
                       *ngIf="initialSavedSearch !== undefined else saveSearchButton"
                       mat-button
@@ -67,7 +66,6 @@
                       {{ 'APP.BROWSE.SEARCH.SAVE_SEARCH.ACTION_BUTTON' | translate }}
                     </button>
                   </ng-template>
-                }
                   <button
                     mat-button
                     adf-reset-search

projects/aca-content/src/lib/components/search/search-results/search-results.component.spec.ts

@@ -29,7 +29,7 @@ import { AppConfigService, NotificationService, TranslationService } from '@alfr
 import { Store } from '@ngrx/store';
 import { NavigateToFolder } from '@alfresco/aca-shared/store';
 import { Pagination, SearchRequest } from '@alfresco/js-api';
-import { SavedSearchesService, SearchQueryBuilderService } from '@alfresco/adf-content-services';
+import { SearchQueryBuilderService } from '@alfresco/adf-content-services';
 import { ActivatedRoute, Event, NavigationStart, Params, Router } from '@angular/router';
 import { BehaviorSubject, Observable, of, Subject, throwError } from 'rxjs';
 import { AppTestingModule } from '../../../testing/app-testing.module';
@@ -42,6 +42,7 @@ import { TestbedHarnessEnvironment } from '@angular/cdk/testing/testbed';
 import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 import { MatMenuModule } from '@angular/material/menu';
 import { MatMenuHarness } from '@angular/material/menu/testing';
+import { SavedSearchesContextService } from '../../../services/saved-searches-context.service';
 
 @Pipe({ name: 'isFeatureSupportedInCurrentAcs' })
 class MockIsFeatureSupportedInCurrentAcsPipe implements PipeTransform {
@@ -96,7 +97,7 @@ describe('SearchComponent', () => {
           }
         },
         {
-          provide: SavedSearchesService,
+          provide: SavedSearchesContextService,
           useValue: {
             getSavedSearches: jasmine
               .createSpy('getSavedSearches')

projects/aca-content/src/lib/components/search/search-results/search-results.component.ts

@@ -30,7 +30,6 @@ import {
   DocumentListComponent,
   ResetSearchDirective,
   SavedSearch,
-  SavedSearchesService,
   SearchConfiguration,
   SearchFilterChipsComponent,
   SearchFormComponent,
@@ -89,6 +88,7 @@ import { combineLatest, of } from 'rxjs';
 import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
 import { MatMenuModule } from '@angular/material/menu';
 import { IsFeatureSupportedInCurrentAcsPipe } from '../../../pipes/is-feature-supported.pipe';
+import { SavedSearchesContextService } from '../../../services/saved-searches-context.service';
 
 @Component({
   imports: [
@@ -155,7 +155,7 @@ export class SearchResultsComponent extends PageComponent implements OnInit {
     private readonly changeDetectorRef: ChangeDetectorRef,
     private readonly route: ActivatedRoute,
     private readonly translationService: TranslationService,
-    private readonly savedSearchesService: SavedSearchesService
+    private readonly savedSearchesService: SavedSearchesContextService
   ) {
     super();
 

projects/aca-content/src/lib/components/search/search-save/dialog/delete/saved-search-delete-dialog.component.spec.ts

@@ -26,14 +26,15 @@ import { ComponentFixture, fakeAsync, TestBed, tick } from '@angular/core/testin
 import { MAT_DIALOG_DATA, MatDialogRef } from '@angular/material/dialog';
 import { of, throwError } from 'rxjs';
 import { SavedSearchDeleteDialogComponent } from './saved-search-delete-dialog.component';
-import { SavedSearch, SavedSearchesService } from '@alfresco/adf-content-services';
+import { SavedSearch } from '@alfresco/adf-content-services';
 import { NotificationService } from '@alfresco/adf-core';
 import { AppTestingModule } from '../../../../../testing/app-testing.module';
+import { SavedSearchesContextService } from '../../../../../services/saved-searches-context.service';
 
 describe('SaveSearchDeleteDialogComponent', () => {
   let fixture: ComponentFixture<SavedSearchDeleteDialogComponent>;
   let notificationService: NotificationService;
-  let savedSearchesService: SavedSearchesService;
+  let savedSearchesService: SavedSearchesContextService;
   let submitButton: HTMLButtonElement;
   let cancelButton: HTMLButtonElement;
 
@@ -52,13 +53,13 @@ describe('SaveSearchDeleteDialogComponent', () => {
       imports: [AppTestingModule, SavedSearchDeleteDialogComponent],
       providers: [
         { provide: MatDialogRef, useValue: dialogRef },
-        { provide: SavedSearchesService, useValue: { deleteSavedSearch: () => of({}) } },
+        { provide: SavedSearchesContextService, useValue: { deleteSavedSearch: () => of({}) } },
         { provide: MAT_DIALOG_DATA, useValue: savedSearchToDelete }
       ]
     });
     dialogRef.close.calls.reset();
     fixture = TestBed.createComponent(SavedSearchDeleteDialogComponent);
-    savedSearchesService = TestBed.inject(SavedSearchesService);
+    savedSearchesService = TestBed.inject(SavedSearchesContextService);
     notificationService = TestBed.inject(NotificationService);
 
     submitButton = fixture.nativeElement.querySelector('#aca-save-search-delete-dialog-submit-button');

projects/aca-content/src/lib/components/search/search-save/dialog/delete/saved-search-delete-dialog.component.ts

@@ -23,14 +23,15 @@
  */
 
 import { Component, Inject, ViewEncapsulation } from '@angular/core';
-import { SavedSearch, SavedSearchesService } from '@alfresco/adf-content-services';
+import { SavedSearch } from '@alfresco/adf-content-services';
 import { MAT_DIALOG_DATA, MatDialogModule, MatDialogRef } from '@angular/material/dialog';
 import { take } from 'rxjs/operators';
 import { NotificationService } from '@alfresco/adf-core';
 import { TranslatePipe } from '@ngx-translate/core';
 import { TitleCasePipe } from '@angular/common';
 import { MatIconModule } from '@angular/material/icon';
 import { MatButtonModule } from '@angular/material/button';
+import { SavedSearchesContextService } from '../../../../../services/saved-searches-context.service';
 
 @Component({
   imports: [TranslatePipe, TitleCasePipe, MatIconModule, MatButtonModule, MatDialogModule],
@@ -46,7 +47,7 @@ export class SavedSearchDeleteDialogComponent {
   constructor(
     private readonly dialog: MatDialogRef<SavedSearchDeleteDialogComponent>,
     private readonly notificationService: NotificationService,
-    private readonly savedSearchesService: SavedSearchesService,
+    private readonly savedSearchesService: SavedSearchesContextService,
     @Inject(MAT_DIALOG_DATA) private readonly data: SavedSearch
   ) {}
 

projects/aca-content/src/lib/components/search/search-save/dialog/edit/saved-search-edit-dialog.component.spec.ts

@@ -26,16 +26,17 @@ import { ComponentFixture, fakeAsync, TestBed, tick } from '@angular/core/testin
 import { MAT_DIALOG_DATA, MatDialogRef } from '@angular/material/dialog';
 import { of, throwError } from 'rxjs';
 import { SavedSearchEditDialogComponent } from './saved-search-edit-dialog.component';
-import { SavedSearch, SavedSearchesService } from '@alfresco/adf-content-services';
+import { SavedSearch } from '@alfresco/adf-content-services';
 import { provideMockStore } from '@ngrx/store/testing';
 import { NotificationService } from '@alfresco/adf-core';
 import { AppTestingModule } from '../../../../../testing/app-testing.module';
+import { SavedSearchesContextService } from '../../../../../services/saved-searches-context.service';
 
 describe('SaveSearchEditDialogComponent', () => {
   let fixture: ComponentFixture<SavedSearchEditDialogComponent>;
   let component: SavedSearchEditDialogComponent;
   let notificationService: NotificationService;
-  let savedSearchesService: SavedSearchesService;
+  let savedSearchesService: SavedSearchesContextService;
   let submitButton: HTMLButtonElement;
 
   const savedSearchToDelete: SavedSearch = {
@@ -54,15 +55,15 @@ describe('SaveSearchEditDialogComponent', () => {
       providers: [
         { provide: MatDialogRef, useValue: dialogRef },
         provideMockStore(),
-        { provide: SavedSearchesService, useValue: { editSavedSearch: () => of({}), getSavedSearches: () => of([]) } },
+        { provide: SavedSearchesContextService, useValue: { editSavedSearch: () => of({}), getSavedSearches: () => of([]) } },
         { provide: MAT_DIALOG_DATA, useValue: savedSearchToDelete }
       ]
     });
     dialogRef.close.calls.reset();
     fixture = TestBed.createComponent(SavedSearchEditDialogComponent);
     component = fixture.componentInstance;
     notificationService = TestBed.inject(NotificationService);
-    savedSearchesService = TestBed.inject(SavedSearchesService);
+    savedSearchesService = TestBed.inject(SavedSearchesContextService);
 
     submitButton = fixture.nativeElement.querySelector('#aca-saved-search-edit-dialog-submit-button');
   });

projects/aca-content/src/lib/components/search/search-save/dialog/edit/saved-search-edit-dialog.component.ts

@@ -23,7 +23,7 @@
  */
 
 import { Component, Inject, ViewEncapsulation } from '@angular/core';
-import { AutoFocusDirective, forbidOnlySpaces, SavedSearch, SavedSearchesService } from '@alfresco/adf-content-services';
+import { AutoFocusDirective, forbidOnlySpaces, SavedSearch } from '@alfresco/adf-content-services';
 import { MAT_DIALOG_DATA, MatDialogModule, MatDialogRef } from '@angular/material/dialog';
 import { take } from 'rxjs/operators';
 import { NotificationService } from '@alfresco/adf-core';
@@ -36,6 +36,7 @@ import { MatButtonModule } from '@angular/material/button';
 import { MatFormFieldModule } from '@angular/material/form-field';
 import { MatInputModule } from '@angular/material/input';
 import { TitleCasePipe } from '@angular/common';
+import { SavedSearchesContextService } from '../../../../../services/saved-searches-context.service';
 
 @Component({
   imports: [
@@ -62,7 +63,7 @@ export class SavedSearchEditDialogComponent {
   constructor(
     private readonly dialog: MatDialogRef<SavedSearchEditDialogComponent>,
     private readonly notificationService: NotificationService,
-    private readonly savedSearchesService: SavedSearchesService,
+    private readonly savedSearchesService: SavedSearchesContextService,
     private readonly uniqueSearchNameValidator: UniqueSearchNameValidator,
     @Inject(MAT_DIALOG_DATA) private readonly data: SavedSearch
   ) {