Improve XSD visual layout and styling#85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
AttributeDeclandGraphPointtypes and extendElementDecl,ComplexType, andGraphEdgeto carry parsed attributes and routed points (web_src/js/features/xsdvisual/types.ts).<xs:attribute>declarations with helpersgetAttrandparseAttributesand attach attributes to inline complex types and element declarations (web_src/js/features/xsdvisual/parse.ts).rankdir: 'LR',nodesep,ranksep,marginx,marginy), increaseNODE_HEIGHT, and attach routed points from the Dagre edge layout intoGraphEdge.pointsusing edge keys (web_src/js/features/xsdvisual/graph.ts).web_src/js/features/xsdvisual/render.ts).type,base,occurs, and a truncatedattributessummary; add an SVG drop-shadow filter and adjust node sizing (web_src/js/features/xsdvisual/render.ts).70vhfor better fit (web_src/js/features/xsdvisual/ui.ts).web_src/css/repo/file-view.css).Testing
Improve XSD visual layout and styling(commit succeeded).mcp__browser_tools__run_playwright_script) to capture the updated renderer, but it failed to load the local dev server withnet::ERR_EMPTY_RESPONSE, so no runtime screenshot was produced.Codex Task