Temporarily remove alpide test and improve ITSRESPONSE location#10542
Merged
ktf merged 2 commits intoAliceO2Group:devfrom Jan 13, 2023
Merged
Temporarily remove alpide test and improve ITSRESPONSE location#10542ktf merged 2 commits intoAliceO2Group:devfrom
ktf merged 2 commits intoAliceO2Group:devfrom
Conversation
mconcas
requested review from
bovulpes,
iouribelikov and
rpezzi
as code owners
mconcas
force-pushed
the
pr-disable-test
branch
from
02c7bf3 to
c606d8b
Compare
mconcas
force-pushed
the
pr-disable-test
branch
from
c606d8b to
a3dddd7
Compare
mconcas
changed the title
Collaborator
Author
|
@ktf this should be part of what we discussed today concerning O2. |
ktf
reviewed
Jan 11, 2023
|
|
||
| add_custom_command(TARGET O2exe-alpide-response-generator POST_BUILD | ||
| COMMAND ${CMAKE_BINARY_DIR}/stage/bin/o2-alpide-response-generator -i $ENV{ITSRESPONSE_ROOT}/response/AlpideResponseData/ -o ${CMAKE_SOURCE_DIR}/Detectors/ITSMFT/common/data/AlpideResponseData/ | ||
| COMMAND ${CMAKE_BINARY_DIR}/stage/bin/o2-alpide-response-generator -i ${ITSRESPONSE_LOCATION}/response/AlpideResponseData/ -o ${CMAKE_SOURCE_DIR}/Detectors/ITSMFT/common/data/AlpideResponseData/ |
Member
There was a problem hiding this comment.
I think the common pattern is to call those variables _DIR. @aphecetche ?
Collaborator
There was a problem hiding this comment.
if intended to be used with e.g. find_package(ITSResponse) _ROOT would even be better I believe, as _DIR are expected to be env variable, as far as I can tell. But would work as well. See https://cmake.org/cmake/help/latest/command/find_package.html#config-mode-search-procedure (in particular the part after "The set of installation prefixes is constructed using the following steps" listing 9 steps).
mconcas
force-pushed
the
pr-disable-test
branch
from
b73adf3 to
9dab385
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is temporary to workaround some sporadic CI tests failures.
It will be reverted after some fixups in the O2 recipe for the AlpideResponse package.