Skip to content

TPC FastSpaceChargeCorrection: add missing member to cloneFromObject#10881

Merged
davidrohr merged 1 commit into
AliceO2Group:devfrom
matthias-kleiner:fixtransform
Mar 5, 2023
Merged

TPC FastSpaceChargeCorrection: add missing member to cloneFromObject#10881
davidrohr merged 1 commit into
AliceO2Group:devfrom
matthias-kleiner:fixtransform

Conversation

@matthias-kleiner
Copy link
Copy Markdown
Contributor

No description provided.

@matthias-kleiner
Copy link
Copy Markdown
Contributor Author

@davidrohr
This fixes the problem we discussed. It was actually done correctly in the past when no correction was applied, and only appears now with #10871

@sgorbuno Can you confirm, that the member was just forgotten to be copied in the cloneFromObject function?

@davidrohr
Copy link
Copy Markdown
Collaborator

@matthias-kleiner : thx for the fix. Does this fix also the problem that removing the setNoCorrection yields a max drift length of 0?

@davidrohr davidrohr merged commit 46228b8 into AliceO2Group:dev Mar 5, 2023
@matthias-kleiner
Copy link
Copy Markdown
Contributor Author

@matthias-kleiner : thx for the fix. Does this fix also the problem that removing the setNoCorrection yields a max drift length of 0?
Yes this fixes the problem. The member containing the drift length was not copied when clonefromobject was called and then the max drift length was reset to 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants