Skip to content

Do not get B field from external file anymore, but from CCDB - O2#11044

Merged
davidrohr merged 2 commits into
AliceO2Group:devfrom
chiarazampolli:geomCCDB
Mar 30, 2023
Merged

Do not get B field from external file anymore, but from CCDB - O2#11044
davidrohr merged 2 commits into
AliceO2Group:devfrom
chiarazampolli:geomCCDB

Conversation

@chiarazampolli
Copy link
Copy Markdown
Collaborator

@chiarazampolli chiarazampolli commented Mar 28, 2023

@knopers8 , @shahor02 goes with:
AliceO2Group/QualityControl#1692
AliceO2Group/O2DPG#977

Tested within async reco and also as standalone with:

o2-global-track-cluster-reader --track-types "TPC,ITS-TPC" --hbfutils-config o2_tfidinfo.root --disable-mc | o2-itstpc-match-qc --disable-mc -b

@chiarazampolli chiarazampolli changed the title Do not get B field from external file anymore, but from CCDB Do not get B field from external file anymore, but from CCDB - O2 Mar 28, 2023
@chiarazampolli chiarazampolli changed the title Do not get B field from external file anymore, but from CCDB - O2 [WIP]Do not get B field from external file anymore, but from CCDB - O2 Mar 28, 2023
@chiarazampolli chiarazampolli force-pushed the geomCCDB branch 2 times, most recently from 17c4040 to 71dae81 Compare March 28, 2023 14:58
@chiarazampolli chiarazampolli changed the title [WIP]Do not get B field from external file anymore, but from CCDB - O2 Do not get B field from external file anymore, but from CCDB - O2 Mar 28, 2023
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI for e406f1c at 2023-03-28 18:12:

## sw/BUILD/QualityControl-latest/log
/sw/SOURCES/QualityControl/v1.95.1/v1.95.1/Modules/GLO/src/ITSTPCMatchingTask.cxx:64:20: error: 'class o2::globaltracking::MatchITSTPCQC' has no member named 'setGRPFileName'; did you mean 'DeclFileName'?
/sw/SOURCES/QualityControl/v1.95.1/v1.95.1/Modules/GLO/src/ITSTPCMatchingTask.cxx:68:20: error: 'class o2::globaltracking::MatchITSTPCQC' has no member named 'setGeomFileName'
ninja: build stopped: cannot make progress due to previous errors.

Full log here.

@chiarazampolli
Copy link
Copy Markdown
Collaborator Author

The error is due to thd dependency between PRs…

chiara

@iravasen
Copy link
Copy Markdown
Contributor

iravasen commented Mar 29, 2023

Hi @chiarazampolli thanks a lot! Few comments:

Let me know if you have troubles, thanks, cheers
Ivan

@chiarazampolli
Copy link
Copy Markdown
Collaborator Author

Hi @iravasen ,
Please, check AliceO2Group/QualityControl@188d7f1, I think this is what you meant (while you pointed at https://github.com/AliceO2Group/QualityControl/blob/22302d0a8ff43cac6372c394ef002319275a92ec/Modules/ITS/src/ITSClusterTask.cxx#L105-L118 where I changed already).
Chiara

@iravasen
Copy link
Copy Markdown
Contributor

Hi @chiarazampolli, sorry I commented the wrong PR and with the wrong link.... my bad.
I continue on QC.

@davidrohr davidrohr merged commit 3a37334 into AliceO2Group:dev Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants