Introduce proper generator IDs#11509
Merged
sawenzel merged 3 commits intoAliceO2Group:devfrom Jul 19, 2023
Merged
Conversation
benedikt-voelkel
force-pushed
the
gen-ids
branch
from
fd78c4c to
ccee093
Compare
Contributor
Author
|
Tested with https://github.com/benedikt-voelkel/O2DPG/tree/cocktail-test
|
benedikt-voelkel
force-pushed
the
gen-ids
branch
3 times, most recently
from
bf1952c to
8885521
Compare
benedikt-voelkel
changed the title
Collaborator
jgrosseo
reviewed
Jul 10, 2023
* 3 values
* global ID assigend to a o2::eventgen::PrimaryGenerator
* cocktail constituent ID in case a o2::eventgen::Generator consists
of multiple cocktail constituents. If a specific constituent is used
for an event, that event will be flagged with that ID
* source ID to mark source in emebdding scenarios
* all 3 values are encoded into a single short, passed to mcCollision
table at the end
* provide decoding via helper functions/dynamic columns in mcCOllision
table
Set the IDs
* Global ID (and short description)
* can be set via
o2-sim --confKeyValues \
"PrimaryGenerator.id=3;PrimaryGenerator.description=a specific gen"
* Each cocktail constituent must first be registered via
o2::eventgen::Generator::addCocktailConstituent(int, std::string)
then, each egnerated event must set a valid ID during
o2::eventgen::Generator::GenerateEvent
or
o2::eventgen::Generator::importParticles
if cocktail constituents are set but no valid ID is given, no event
will be generated
* source ID is derived by the framework as before, not up to the user
* combine MC Gen ID and particle status to MCGenProperties
(naming not final, MCGenHelper, MCGenUtils?)
Please consider the following formatting changes
benedikt-voelkel
force-pushed
the
gen-ids
branch
from
8885521 to
c6fd02f
Compare
* rename cocktail to subGenerator everywhere * a cocktail should stay a cocktail of different generators * remove comment in AnalysisDataModel
benedikt-voelkel
force-pushed
the
gen-ids
branch
from
2f00332 to
aefad0c
Compare
* generator ID from 0 to 127 (included) * sub-generator ID from -1 to 30 (included) * source ID from 0 to 15 (included)
Collaborator
mwinn2
pushed a commit
to mwinn2/AliceO2
that referenced
this pull request
Aug 24, 2023
* Introduce proper generator IDs
* 3 values
* global ID assigend to a o2::eventgen::PrimaryGenerator
* cocktail constituent ID in case a o2::eventgen::Generator consists
of multiple cocktail constituents. If a specific constituent is used
for an event, that event will be flagged with that ID
* source ID to mark source in emebdding scenarios
* all 3 values are encoded into a single short, passed to mcCollision
table at the end
* provide decoding via helper functions/dynamic columns in mcCOllision
table
Set the IDs
* Global ID (and short description)
* can be set via
o2-sim --confKeyValues \
"PrimaryGenerator.id=3;PrimaryGenerator.description=a specific gen"
* Each cocktail constituent must first be registered via
o2::eventgen::Generator::addCocktailConstituent(int, std::string)
then, each egnerated event must set a valid ID during
o2::eventgen::Generator::GenerateEvent
or
o2::eventgen::Generator::importParticles
if cocktail constituents are set but no valid ID is given, no event
will be generated
* source ID is derived by the framework as before, not up to the user
* combine MC Gen ID and particle status to MCGenProperties
(naming not final, MCGenHelper, MCGenUtils?)
Please consider the following formatting changes
* Be consistent with Run1 and Run2
* rename cocktail to subGenerator everywhere
* a cocktail should stay a cocktail of different generators
* remove comment in AnalysisDataModel
* Adjust ID ranges
* generator ID from 0 to 127 (included)
* sub-generator ID from -1 to 30 (included)
* source ID from 0 to 15 (included)
---------
Co-authored-by: Benedikt Volkel <benedikt.volkel@cern.ch>
fcatalan92
pushed a commit
to fcatalan92/AliceO2
that referenced
this pull request
Dec 20, 2023
* Introduce proper generator IDs
* 3 values
* global ID assigend to a o2::eventgen::PrimaryGenerator
* cocktail constituent ID in case a o2::eventgen::Generator consists
of multiple cocktail constituents. If a specific constituent is used
for an event, that event will be flagged with that ID
* source ID to mark source in emebdding scenarios
* all 3 values are encoded into a single short, passed to mcCollision
table at the end
* provide decoding via helper functions/dynamic columns in mcCOllision
table
Set the IDs
* Global ID (and short description)
* can be set via
o2-sim --confKeyValues \
"PrimaryGenerator.id=3;PrimaryGenerator.description=a specific gen"
* Each cocktail constituent must first be registered via
o2::eventgen::Generator::addCocktailConstituent(int, std::string)
then, each egnerated event must set a valid ID during
o2::eventgen::Generator::GenerateEvent
or
o2::eventgen::Generator::importParticles
if cocktail constituents are set but no valid ID is given, no event
will be generated
* source ID is derived by the framework as before, not up to the user
* combine MC Gen ID and particle status to MCGenProperties
(naming not final, MCGenHelper, MCGenUtils?)
Please consider the following formatting changes
* Be consistent with Run1 and Run2
* rename cocktail to subGenerator everywhere
* a cocktail should stay a cocktail of different generators
* remove comment in AnalysisDataModel
* Adjust ID ranges
* generator ID from 0 to 127 (included)
* sub-generator ID from -1 to 30 (included)
* source ID from 0 to 15 (included)
---------
Co-authored-by: Benedikt Volkel <benedikt.volkel@cern.ch>
benedikt-voelkel
pushed a commit
that referenced
this pull request
Jan 9, 2024
* Introduce proper generator IDs (#11509) * Introduce proper generator IDs * 3 values * global ID assigend to a o2::eventgen::PrimaryGenerator * cocktail constituent ID in case a o2::eventgen::Generator consists of multiple cocktail constituents. If a specific constituent is used for an event, that event will be flagged with that ID * source ID to mark source in emebdding scenarios * all 3 values are encoded into a single short, passed to mcCollision table at the end * provide decoding via helper functions/dynamic columns in mcCOllision table Set the IDs * Global ID (and short description) * can be set via o2-sim --confKeyValues \ "PrimaryGenerator.id=3;PrimaryGenerator.description=a specific gen" * Each cocktail constituent must first be registered via o2::eventgen::Generator::addCocktailConstituent(int, std::string) then, each egnerated event must set a valid ID during o2::eventgen::Generator::GenerateEvent or o2::eventgen::Generator::importParticles if cocktail constituents are set but no valid ID is given, no event will be generated * source ID is derived by the framework as before, not up to the user * combine MC Gen ID and particle status to MCGenProperties (naming not final, MCGenHelper, MCGenUtils?) Please consider the following formatting changes * Be consistent with Run1 and Run2 * rename cocktail to subGenerator everywhere * a cocktail should stay a cocktail of different generators * remove comment in AnalysisDataModel * Adjust ID ranges * generator ID from 0 to 127 (included) * sub-generator ID from -1 to 30 (included) * source ID from 0 to 15 (included) --------- Co-authored-by: Benedikt Volkel <benedikt.volkel@cern.ch> * Avoid warnings when looking for MCEventHeader info in particular avoid problem retrieving info 'subgenerator_id': no such key * Fix typo in subGenerator check --------- Co-authored-by: Benedikt Volkel <benedikt.volkel@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 values forseen
of multiple cocktail constituents. If a specific constituent is used
for an event, that event will be flagged with that ID
all 3 values are encoded into a single short, passed to mcCollision
table at the end
provide decoding via helper functions
Global ID (and short description)
o2-sim --confKeyValues
"PrimaryGenerator.id=3;PrimaryGenerator.description=a specific gen"
Each cocktail constituent must first be registered via
o2::eventgen::Generator::addCocktailConstituent(int, std::string)
then, each egnerated event must set a valid ID during
o2::eventgen::Generator::GenerateEvent
or
o2::eventgen::Generator::importParticles
if cocktail constituents are set but no valid ID is given, no event
will be generated