Conversation
| void polygon(const o2::mch::contour::Polygon<T>& p) | ||
| { | ||
| mSVGBuffer << R"(<polygon points=")"; | ||
| mSVGBuffer << R"(<polygon fill="blue" points=")"; |
There was a problem hiding this comment.
I guess this is a leftover from a test. Please remove it, as there's no point in hard coding a color here.
| include/MCHEvaluation/Draw.h | ||
| LINKDEF src/MCHEvaluationLinkDef.h) | ||
|
|
||
| o2_add_executable(map_mch |
There was a problem hiding this comment.
map_mch is not a terribly good name 😉
Especially considering the executable name will be o2-mch-map_mch which stutters on Mch and does not respect the executable naming convention.
What about something along the lines of clustermap-display or clustermap-plotter ? @mguilbau any opinion here ?
There was a problem hiding this comment.
Clustermap-display is my preferred
| The general purpose is to track "unexpected" detector issues not well reproduced with MC simulations. These problems generate non-negligible bias in Acc*Eff corrections resulting in large tracking systematic uncertainties. | ||
|
|
||
| During the data reconstruction, the status of the detector is calculated with the CCDB which is used to discard most of the detector issues. | ||
| This status map is built with information based on pedestals, high voltage tension, occupancy etc. |
There was a problem hiding this comment.
high voltage is not currently included in the computation of the statusmap. It's planned, but not yet done.
| Nevertheless, some detector issues (e.g. a cable swapping) are not well detected online and consequently not properly reproduced by the CCBD. | ||
| The main objective of this code is to spot these issues not included in the status map. | ||
|
|
||
| Input files used: |
There was a problem hiding this comment.
I guess the documentation on how to use this program should be primarily seen from the point of the view of the next person that will use it to produce cluster map comparisons, not so much develop the code. So how to get the input files should be part of the documentation for instance. (by the way that doc could be put in a separate .md file to keep the main README.md more as an index.
| COMPILATION (commands): | ||
|
|
||
| cd alice ==> alienv enter O2/latest | ||
| cd sw/BUILD/O2-latest/O2 ==> cmake --build . |
There was a problem hiding this comment.
this is kind of an expert way of working and is only relevant for people developing the code, not simply using it, so I'd remove it from this doc.
|
|
||
| OPEN OUTPUT FILES: | ||
|
|
||
| cd outputfile ==> open CHAMBERS-1-NB.html CHAMBERS-2-NB.html CHAMBERS-3-NB.html CHAMBERS-4-NB.html CHAMBERS-5-NB.html CHAMBERS-6-NB.html CHAMBERS-7-NB.html CHAMBERS-8-NB.html CHAMBERS-9-NB.html CHAMBERS-10-NB.html |
There was a problem hiding this comment.
I believe the open command is a Mac-only thing, so not reproducible e.g. on a Linux machine. Either change it to plain English (open in your preferred browser the CHAMBERS*.html files generated) or provide the equivalent Linux command...
|
will review the "meat" of the PR (the actual map_mch code) later on... |
|
This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days. |
3 participants
No description provided.