Skip to content

SVertexer: add V0 Photontune#12332

Merged
shahor02 merged 3 commits into
AliceO2Group:devfrom
f3sch:v0/optimize
Dec 1, 2023
Merged

SVertexer: add V0 Photontune#12332
shahor02 merged 3 commits into
AliceO2Group:devfrom
f3sch:v0/optimize

Conversation

@f3sch
Copy link
Copy Markdown
Collaborator

@f3sch f3sch commented Nov 27, 2023

pingin @shahor02

@f3sch f3sch requested a review from shahor02 November 27, 2023 12:19
Comment thread Detectors/Vertexing/StrangenessTracking/src/StrangenessTracker.cxx Outdated
Comment thread Detectors/Vertexing/include/DetectorsVertexing/SVertexer.h Outdated
Comment thread Detectors/Vertexing/include/DetectorsVertexing/SVertexer.h Outdated
Comment thread Detectors/Vertexing/include/DetectorsVertexing/SVertexerParams.h Outdated
Comment thread Detectors/Vertexing/include/DetectorsVertexing/SVertexerParams.h Outdated
Comment thread Detectors/Vertexing/src/SVertexer.cxx Outdated
Comment thread Detectors/Vertexing/src/SVertexer.cxx Outdated
Comment thread Detectors/Vertexing/src/SVertexer.cxx
Comment thread Detectors/Vertexing/src/SVertexer.cxx Outdated
Comment thread Detectors/Vertexing/src/SVertexer.cxx Outdated
Comment thread Detectors/Vertexing/src/SVertexer.cxx Outdated
@shahor02 shahor02 marked this pull request as ready for review November 27, 2023 20:32
@shahor02 shahor02 requested a review from a team as a code owner November 27, 2023 20:32
@shahor02
Copy link
Copy Markdown
Collaborator

Looks good (still to be clarified if we exclude all tracks w/o ITS from anything but photons), removing draft tag.
Would be good do get timing with this version.

@f3sch f3sch force-pushed the v0/optimize branch 6 times, most recently from 81003f4 to 6b5d646 Compare November 29, 2023 21:20
Signed-off-by: Felix Schlepper <f3sch.git@outlook.com>
@f3sch
Copy link
Copy Markdown
Collaborator Author

f3sch commented Nov 30, 2023

I checked that now that when one uses svertexer.mExcludeTPCtracks=true and set TPC as vertexing-source as is needed by the cascade-finder the. One gets the exact same output as with the dev branch and this PR
I checked this by dumping the indices with root -b -q -l -e 'TTree *t; (TFile::Open("o2_secondary_vertex.root"))->GetObject("o2sim", t); t->SetScanField(0); t->Scan("*");' > scanBase.out.txt for both branches and compared the hash of the output file, which are the same, and I plotted the v0,cascade,3body radius when one creates the full kinematics, e.g., svertexer.createFullV0s=true.

Untitled 001

So this PR will reproduce the old behaviour and not interfere if svertexer.mExcludeTPCtracks=true is set. Of course this tuning will only affect tpc-only tracks, so if svertexer.mExcludeTPCtracks=false, there will only be V0s produced on top of the V0s one from the dev branch (with the reduced photon mass-width, which is validated at 100 MeV to be fully sufficient), and the cascades/3body are not touched at all meaning the all the ones found with the current dev branch will be found, no more no less.

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI for 77d0643 at 2023-11-30 20:47:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/QualityControl-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile reco_ASYNC.log
[73804:internal-dpl-ccdb-backend]: [19:46:55][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/GLO/Config/SVertexerParam for 1550600800000 (agent_id: alissandra02-1701373601-EjSmcg) with http code: 404
[73804:internal-dpl-ccdb-backend]: [19:46:55][ERROR] File GLO/Config/SVertexerParam could not be retrieved. No more hosts to try.
[73812:ctp-entropy-decoder]: [19:46:55][ERROR] LM:202 L0:0 L1:1 TwI:3 Trigger classes wo input:166
[ERROR] pid 73853 (secondary-vertexing) crashed with or was killed with exit code 1
[ERROR]  - Device secondary-vertexing: pid 73853 (exit 1)
[ERROR] SEVERE: Device secondary-vertexing (73853) returned with 1


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/d0fd8663a2a1df8ca41d21cd4389e7245bb576a9/slc8_x86-64/o2checkcode/1.0-local177/etc/modulefiles
++ cat
--

Full log here.

Copy link
Copy Markdown
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures unrelated, relevant fullCI passed, merging.

@shahor02 shahor02 merged commit 0493ad2 into AliceO2Group:dev Dec 1, 2023
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
* SVertexer: V0 Photon tuning

Signed-off-by: Felix Schlepper <f3sch.git@outlook.com>

* SVertexer: load config params form ccdb

* Dummy commit to retrigger fullCI

---------

Signed-off-by: Felix Schlepper <f3sch.git@outlook.com>
Co-authored-by: Felix Schlepper <f3sch@macfelix.dyndns.cern.ch>
Co-authored-by: Ruben Shahoyan <shahor02@users.noreply.github.com>
mwinn2 pushed a commit to mwinn2/AliceO2 that referenced this pull request Apr 25, 2024
* SVertexer: V0 Photon tuning

Signed-off-by: Felix Schlepper <f3sch.git@outlook.com>

* SVertexer: load config params form ccdb

* Dummy commit to retrigger fullCI

---------

Signed-off-by: Felix Schlepper <f3sch.git@outlook.com>
Co-authored-by: Felix Schlepper <f3sch@macfelix.dyndns.cern.ch>
Co-authored-by: Ruben Shahoyan <shahor02@users.noreply.github.com>
@f3sch f3sch deleted the v0/optimize branch November 25, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants