[EMCAL-539,EMCAL-696,EMCAL-697] First version of the L0 trigger imple… by siragoni · Pull Request #12362 · AliceO2Group/AliceO2

siragoni · 2023-11-30T10:16:23Z

…mentation

Added:

TRU time response
Pileup simulation at trigger level
Peak finder and L0 algorithm

Simulation not yet implemented in the EMCALDigitizerSPEC

…mentation Added: - TRU time response - Pileup simulation at trigger level - Peak finder and L0 algorithm Simulation not yet implemented in the EMCALDigitizerSPEC

mfasDa

For the moment one small request from my side

Detectors/EMCAL/simulation/include/EMCALSimulation/DigitTimebin.h

…ng forward declaration DigitTimebin<template>

mfasDa

First set of change requests. There are two things that are different between trigger and FEE, and because the code is adapted from FEE it is consequently wrong:

a) Phase: FEE has a 10 MHz clock, while the LHC has a 40 MHz clock, consequently the deposited charge per sample depends on the relative BC between LHC and ALTRO clock
b) Noise: FEE has 2 digitizers, with different noise, and we decide only at reconstruction level based on the energy of the full raw fit which of the two to take. Consequently we must simulate for each digit both high and low gain noise. The trigger system has only one digitizer and consequently only one noise value, which is a lot easier to handle.

Detectors/EMCAL/simulation/include/EMCALSimulation/Patches.h

Detectors/EMCAL/simulation/include/EMCALSimulation/LZEROElectronics.h

Detectors/EMCAL/simulation/include/EMCALSimulation/DigitizerTRU.h

Detectors/EMCAL/simulation/include/EMCALSimulation/DigitTimebin.h

Detectors/EMCAL/simulation/include/EMCALSimulation/LZEROElectronics.h

Detectors/EMCAL/simulation/src/LZEROElectronics.cxx

Detectors/EMCAL/simulation/src/Patches.cxx

…ng choice for indexing patches

…TRU TRF, verbosity

mfasDa

Next round of change requests. Will still need to go through in more details through the LZERO for the next round. For the moment please focus on those changes.

Detectors/EMCAL/simulation/include/EMCALSimulation/DigitizerTRU.h

Detectors/EMCAL/simulation/include/EMCALSimulation/LZEROElectronics.h

Detectors/EMCAL/simulation/src/DigitizerTRU.cxx

mfasDa

Quite some adjustments needed particularly in the "Patches" struct - which has a misleading name. I will review more the UpdateADC function once the code is a bit simplified based on the comments in this review.

Detectors/EMCAL/simulation/src/LZEROElectronics.cxx

Detectors/EMCAL/simulation/src/Patches.cxx

Detectors/EMCAL/simulation/include/EMCALSimulation/Patches.h

Detectors/EMCAL/simulation/src/Patches.cxx

…TRUElectronics

…sses, demote verbosity

shahor02

Conditional approval to start CI of 1st commit

siragoni · 2024-02-01T14:56:59Z

Good evening @shahor02 , I unfortunately overwrote your approval. Could you please give it again? I think it is needed since I am actually a first time committer...

martenole

Conditional to start CI again

shahor02

now it takes some time to acknowledge the approval (done when actual build starts).

shahor02

it takes some time to update the status after the approval.

alibuild · 2024-02-02T04:06:02Z

Error while checking build/O2/fullCI for 5a90793 at 2024-02-02 05:06:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/TRUElectronics.cxx:200:32: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/LZEROElectronics.cxx:179:31: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/LZEROElectronics.cxx:183:27: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/DigitizerTRU.cxx:296:65: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/DigitizerTRU.cxx:299:72: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/DigitizerTRU.cxx:360:30: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/DigitizerTRU.cxx:362:30: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/DigitizerTRU.cxx:364:30: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/DigitizerTRU.cxx:366:30: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/DigitizerTRU.cxx:368:30: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/DigitizerTRU.cxx:370:30: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/DigitizerTRU.cxx:372:30: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/DigitizerTRU.cxx:374:30: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/DigitizerTRU.cxx:376:30: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/DigitizerTRU.cxx:378:30: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/DigitizerTRU.cxx:382:30: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/DigitizerTRU.cxx:384:30: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/DigitizerTRU.cxx:386:30: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/DigitizerTRU.cxx:388:30: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/DigitizerTRU.cxx:390:30: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/Detectors/EMCAL/simulation/src/DigitizerTRU.cxx:392:30: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:29:7: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:29:7: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:52:5: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:53:5: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:73:38: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:74:38: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:83:5: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:84:5: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:101:5: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:101:14: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:108:37: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:108:45: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:109:49: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:109:63: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:118:11: error: field declaration 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:119:11: error: field declaration 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:29:7: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
[0 more errors; see full log]

Full log here.

mfasDa · 2024-02-02T08:36:03Z

CI errors unrelated

siragoni · 2024-02-02T09:21:59Z

Hi everyone, just to clarify, I see that the errors are all related to statements like:

      if (foundPeakCurrentTRU)
        foundPeak = true;

Since I see that the build fails with output error: statement should be inside braces [readability-braces-around-statements] may I please ask you to confirm whether all this statements should be of the form

     if (foundPeakCurrentTRU) {
       foundPeak = true;
     }

instead? With clang-format -i of course. Thank you

alibuild · 2024-02-02T15:15:39Z

Error while checking build/O2/fullCI for b9fc0d8 at 2024-02-02 16:15:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:29:7: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:29:7: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:52:5: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:53:5: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:73:38: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:74:38: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:83:5: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:84:5: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:101:5: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:101:14: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:108:37: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:108:45: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:109:49: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:109:63: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:118:11: error: field declaration 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:119:11: error: field declaration 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:29:7: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:29:7: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:52:5: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:53:5: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:73:38: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:74:38: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:83:5: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:84:5: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:101:5: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:101:14: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:108:37: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:108:45: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:109:49: error: field reference 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:109:63: error: field reference 'nChanC' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:118:11: error: field declaration 'nChanA' does not match naming rule [aliceO2-member-name]
/sw/SOURCES/O2/12362-slc8_x86-64/0/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h:119:11: error: field declaration 'nChanC' does not match naming rule [aliceO2-member-name]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

siragoni · 2024-02-02T16:57:15Z

Good evening everyone, could you please clarify whether this is an issue on my side or something else?

shahor02 · 2024-02-02T17:25:10Z

No, it fails for the reason which should be already fixed. But given the amount of changes, better of we wait for the fullCI to rerun and become green.

mfasDa

Now it is fine to merge. @shahor02 Please do a squash merge and keep ONLY the commit message of the initial commit.

[EMCAL-539,EMCAL-696,EMCAL-697] First version of the L0 trigger imple…

ce500a4

…mentation Added: - TRU time response - Pileup simulation at trigger level - Peak finder and L0 algorithm Simulation not yet implemented in the EMCALDigitizerSPEC

siragoni requested review from jokonig and mfasDa as code owners November 30, 2023 10:16

mfasDa requested changes Dec 1, 2023

View reviewed changes

Detectors/EMCAL/simulation/include/EMCALSimulation/DigitTimebin.h Outdated Show resolved Hide resolved

siragoni added 2 commits December 1, 2023 16:37

[EMCAL-539,EMCAL-696,EMCAL-697] Suppress DigitizerTRU verbosity, movi…

389e2e3

…ng forward declaration DigitTimebin<template>

[EMCAL-539,EMCAL-696,EMCAL-697] Clang formatting DigitTimebin

724475d

mfasDa self-requested a review December 8, 2023 09:25

mfasDa requested changes Dec 8, 2023

View reviewed changes

siragoni added 2 commits December 8, 2023 17:30

[EMCAL-539,EMCAL-696,EMCAL-697] Remove verbosity, extra headers, nami…

610c35e

…ng choice for indexing patches

[EMCAL-539,EMCAL-696,EMCAL-697] SimParam handles trigger parameters, …

d39712b

…TRU TRF, verbosity

mfasDa requested changes Dec 23, 2023

View reviewed changes

mfasDa requested changes Dec 24, 2023

View reviewed changes

siragoni added 3 commits January 8, 2024 17:31

[EMCAL-539,EMCAL-696,EMCAL-697] SimParam handles trigger parameters, …

d7a7a98

…TRUElectronics

[EMCAL-539,EMCAL-696,EMCAL-697] SimParam handles trigger parameters, …

d77185d

…TRUElectronics

[EMCAL-539,EMCAL-696,EMCAL-697] Removing pointers from L0-related cla…

0fbe3b2

…sses, demote verbosity

shahor02 previously approved these changes Feb 1, 2024

View reviewed changes

[EMCAL-539,EMCAL-696,EMCAL-697] Merge conflict solve

d37e145

siragoni dismissed shahor02’s stale review via d37e145 February 1, 2024 14:37

siragoni added 2 commits February 1, 2024 15:38

[EMCAL-539,EMCAL-696,EMCAL-697] Merge conflict solve

8940468

[EMCAL-539,EMCAL-696,EMCAL-697] Merge conflict solve

5a90793

martenole previously approved these changes Feb 1, 2024

View reviewed changes

shahor02 approved these changes Feb 1, 2024

View reviewed changes

shahor02 previously approved these changes Feb 1, 2024

View reviewed changes

[EMCAL-539,EMCAL-696,EMCAL-697] Extra brackets

b9fc0d8

siragoni dismissed stale reviews from shahor02 and martenole via b9fc0d8 February 2, 2024 14:22

mfasDa self-requested a review February 5, 2024 09:00

mfasDa approved these changes Feb 5, 2024

View reviewed changes

mfasDa merged commit a8520d5 into AliceO2Group:dev Feb 5, 2024

siragoni deleted the EMCAL-539 branch February 5, 2024 15:57

Conversation

siragoni commented Nov 30, 2023

Uh oh!

mfasDa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mfasDa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mfasDa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mfasDa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shahor02 left a comment

Choose a reason for hiding this comment

Uh oh!

siragoni commented Feb 1, 2024

Uh oh!

martenole left a comment

Choose a reason for hiding this comment

Uh oh!

shahor02 left a comment

Choose a reason for hiding this comment

Uh oh!

shahor02 left a comment

Choose a reason for hiding this comment

Uh oh!

alibuild commented Feb 2, 2024

Uh oh!

mfasDa commented Feb 2, 2024

Uh oh!

siragoni commented Feb 2, 2024

Uh oh!

alibuild commented Feb 2, 2024

Uh oh!

siragoni commented Feb 2, 2024

Uh oh!

shahor02 commented Feb 2, 2024

Uh oh!

mfasDa left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants