Create and pass v0 flag to AOD by shahor02 · Pull Request #12443 · AliceO2Group/AliceO2

shahor02 · 2023-12-11T22:00:10Z

No description provided.

shahor02 · 2023-12-11T22:01:54Z

Detectors/AOD/src/AODProducerWorkflowSpec.cxx

    }
    if (posTableIdx != -1 and negTableIdx != -1 and collID != -1) {
-      v0Cursor(collID, posTableIdx, negTableIdx);
+      v0Cursor(collID, posTableIdx, negTableIdx, v0flags);


@ddobrigk at the moment compilation fails here with

/home/shahoian/alice/sw/SOURCES/O2/dev/0/Framework/Core/include/Framework/AnalysisHelpers.h: In instantiation of 'void o2::framework::WritingCursor<o2::soa::Table<C ...> >::operator()(T ...) [with T = {int, int, int, unsigned char}; PC = {o2::aod::v0::CollisionId, o2::aod::v0::PosTrackId, o2::aod::v0::NegTrackId}]': /home/shahoian/alice/sw/SOURCES/O2/dev/0/Detectors/AOD/src/AODProducerWorkflowSpec.cxx:1180:15: required from 'void o2::aodproducer::AODProducerWorkflowDPL::fillSecondaryVertices(const o2::globaltracking::RecoContainer&, V0CursorType&, CascadeCursorType&, Decay3BodyCursorType&) [with V0CursorType = o2::framework::Produces<o2::soa::Table<o2::soa::Index<0, -1>, o2::aod::v0::CollisionId, o2::aod::v0::PosTrackId, o2::aod::v0::NegTrackId> >; CascadeCursorType = o2::framework::Produces<o2::soa::Table<o2::soa::Index<0, -1>, o2::aod::cascade::CollisionId, o2::aod::cascade::V0Id, o2::aod::cascade::BachelorId> >; Decay3bodyCursorType = o2::framework::Produces<o2::soa::Table<o2::soa::Index<0, -1>, o2::aod::decay3body::CollisionId, o2::aod::decay3body::Track0Id, o2::aod::decay3body::Track1Id, o2::aod::decay3body::Track2Id> >]' /home/shahoian/alice/sw/SOURCES/O2/dev/0/Detectors/AOD/src/AODProducerWorkflowSpec.cxx:2117:24: required from here /home/shahoian/alice/sw/SOURCES/O2/dev/0/Framework/Core/include/Framework/AnalysisHelpers.h:48:33: error: static assertion failed: Argument number mismatch 48 | static_assert(sizeof...(PC) == sizeof...(T), "Argument number mismatch");

alibuild · 2023-12-12T00:04:58Z

Error while checking build/O2/fullCI for d3b0c1e at 2023-12-12 01:04:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/12443-slc8_x86-64/0/Framework/Core/include/Framework/AnalysisHelpers.h:48:33: error: static assertion failed: Argument number mismatch
/sw/SOURCES/O2/12443-slc8_x86-64/0/Framework/Core/include/Framework/AnalysisHelpers.h:50:11: error: no match for call to '(o2::framework::{anonymous}::memfun_type<void (o2::framework::TableBuilder::persist<int, int, int>(const std::array<const char*, 3>&)::<lambda(unsigned int, o2::framework::BuilderMaker<int>::FillType, o2::framework::BuilderMaker<int>::FillType, o2::framework::BuilderMaker<int>::FillType)>::*)(unsigned int, int, int, int) const>::type {aka std::function<void(unsigned int, int, int, int)>}) (int, const int&, const int&, const int&, const unsigned char&)'
ninja: build stopped: subcommand failed.

Full log here.

ddobrigk · 2023-12-13T09:18:47Z

Thanks a lot, @shahor02 , indeed now the converter is merged so we can switch to V0s_002 and finish this!

shahor02 · 2023-12-13T09:36:44Z

@ddobrigk did a test on 2 TFs, svertexer reports

Found 24988 V0s (19313445 fits), 629 cascades (622716 fits), 28009 3-body decays (7136737 fits), 89 strange tracks. Timing: CPU: 9.66 Real: 5.03 s
Found 25401 V0s (18288144 fits), 1011 cascades (688061 fits), 31994 3-body decays (7711925 fits), 72 strange tracks. Timing: CPU: 6.43 Real: 1.74 s

and O2v0_002->fV0Type shows (0: v0 saved for the only due to the cascade, 1: standalone v0, 3: standard v0 with photon-only test done due to the presence of TPC-only track):

To me looks reasonable. The only doubt I have is: as far as I understand, in the old AODs the fV0Type will be set to 0, so all v0s will look like saved for the cascade only. Can avoid this with some defaults or shall I swap the bits in the AODProducer to have "0: standard v0, 1: photon v0, 2: v0 for cascade" ?

ddobrigk · 2023-12-13T09:47:10Z

@ddobrigk did a test on 2 TFs, svertexer reports
Found 24988 V0s (19313445 fits), 629 cascades (622716 fits), 28009 3-body decays (7136737 fits), 89 strange tracks. Timing: CPU: 9.66 Real: 5.03 s
Found 25401 V0s (18288144 fits), 1011 cascades (688061 fits), 31994 3-body decays (7711925 fits), 72 strange tracks. Timing: CPU: 6.43 Real: 1.74 s
and O2v0_002->fV0Type shows (0: v0 saved for the only due to the cascade, 1: standalone v0, 3: standard v0 with photon-only test done due to the presence of TPC-only track):

To me looks reasonable. The only doubt I have is: as far as I understand, in the old AODs the fV0Type will be set to 0, so all v0s will look like saved for the cascade only. Can avoid this with some defaults or shall I swap the bits in the AODProducer to have "0: standard v0, 1: photon v0, 2: v0 for cascade" ?

Hi @shahor02, no, this is unnecessary here because the default in case this isn't in the AO2D (i.e. for old AO2Ds) is defined in the V0 converter inside O2Physics and isn't necessarily zero. At the moment I set the default to 255, but actually now that we also incorporated the photons, I should set it simply to 1 to flag everything as a standard V0.

alibuild · 2023-12-13T10:57:17Z

Error while checking build/O2/fullCI for 22f2093 at 2023-12-13 11:57:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/slc8_x86-64/O2/12443-slc8_x86-64-local1/include/Framework/AnalysisHelpers.h:48:33: error: static assertion failed: Argument number mismatch
/sw/slc8_x86-64/O2/12443-slc8_x86-64-local1/include/Framework/AnalysisHelpers.h:50:11: error: no match for call to '(o2::framework::{anonymous}::memfun_type<void (o2::framework::TableBuilder::persist<int, int, int, unsigned char>(const std::array<const char*, 4>&)::<lambda(unsigned int, o2::framework::BuilderMaker<int>::FillType, o2::framework::BuilderMaker<int>::FillType, o2::framework::BuilderMaker<int>::FillType, o2::framework::BuilderMaker<unsigned char>::FillType)>::*)(unsigned int, int, int, int, unsigned char) const>::type {aka std::function<void(unsigned int, int, int, int, unsigned char)>}) (int, const int&, const int&, const int&)'
/sw/slc8_x86-64/O2/12443-slc8_x86-64-local1/include/Framework/AnalysisHelpers.h:48:33: error: static assertion failed: Argument number mismatch
/sw/slc8_x86-64/O2/12443-slc8_x86-64-local1/include/Framework/AnalysisHelpers.h:50:11: error: no match for call to '(o2::framework::{anonymous}::memfun_type<void (o2::framework::TableBuilder::persist<int, int, int, unsigned char>(const std::array<const char*, 4>&)::<lambda(unsigned int, o2::framework::BuilderMaker<int>::FillType, o2::framework::BuilderMaker<int>::FillType, o2::framework::BuilderMaker<int>::FillType, o2::framework::BuilderMaker<unsigned char>::FillType)>::*)(unsigned int, int, int, int, unsigned char) const>::type {aka std::function<void(unsigned int, int, int, int, unsigned char)>}) (int, const int&, const long int&, const long int&)'
ninja: build stopped: subcommand failed.

Full log here.

shahor02 · 2023-12-13T11:31:26Z

@ddobrigk the fullCI fails in the analysis, could you please check?
We should try to merge this PR this afternoon

ddobrigk · 2023-12-13T12:11:27Z

@ddobrigk the fullCI fails in the analysis, could you please check? We should try to merge this PR this afternoon

Hi Ruben, yes, see here: AliceO2Group/O2Physics#4156

shahor02 · 2023-12-13T13:52:54Z

tested locally, CIs failing due the fix in the O2Physics not merged yet.
Merging.

* Flag standalone and photon V0s in the V0Index * Pass v0 flags to AOD * Set v0s_002 as default --------- Co-authored-by: shahoian <ruben.shahoyan@cern.ch>

shahor02 requested review from a team as code owners December 11, 2023 22:00

shahor02 commented Dec 11, 2023

View reviewed changes

shahor02 added 3 commits December 13, 2023 09:37

Flag standalone and photon V0s in the V0Index

ec56a61

Pass v0 flags to AOD

22faf15

Set v0s_002 as default

22f2093

shahor02 force-pushed the pr_v0flagAOD branch from d3b0c1e to 22f2093 Compare December 13, 2023 09:16

shahor02 mentioned this pull request Dec 13, 2023

Flag standalone V0s in the V0Index #12441

Closed

shahor02 merged commit 2fdcd65 into AliceO2Group:dev Dec 13, 2023

shahor02 deleted the pr_v0flagAOD branch December 13, 2023 13:53

chiarazampolli pushed a commit that referenced this pull request Dec 13, 2023

Create and pass v0 flag to AOD (#12443)

ead09a6

* Flag standalone and photon V0s in the V0Index * Pass v0 flags to AOD * Set v0s_002 as default --------- Co-authored-by: shahoian <ruben.shahoyan@cern.ch>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create and pass v0 flag to AOD#12443

Create and pass v0 flag to AOD#12443
shahor02 merged 3 commits intoAliceO2Group:devfrom
shahor02:pr_v0flagAOD

shahor02 commented Dec 11, 2023

Uh oh!

shahor02 Dec 11, 2023

Uh oh!

alibuild commented Dec 12, 2023

Uh oh!

ddobrigk commented Dec 13, 2023

Uh oh!

shahor02 commented Dec 13, 2023

Uh oh!

ddobrigk commented Dec 13, 2023

Uh oh!

alibuild commented Dec 13, 2023

Uh oh!

shahor02 commented Dec 13, 2023

Uh oh!

ddobrigk commented Dec 13, 2023

Uh oh!

shahor02 commented Dec 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

shahor02 commented Dec 11, 2023

Uh oh!

shahor02 Dec 11, 2023

Choose a reason for hiding this comment

Uh oh!

alibuild commented Dec 12, 2023

Uh oh!

ddobrigk commented Dec 13, 2023

Uh oh!

shahor02 commented Dec 13, 2023

Uh oh!

ddobrigk commented Dec 13, 2023

Uh oh!

alibuild commented Dec 13, 2023

Uh oh!

shahor02 commented Dec 13, 2023

Uh oh!

ddobrigk commented Dec 13, 2023

Uh oh!

shahor02 commented Dec 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants