ITS and MFT dead damp builder workflow#12459
Merged
shahor02 merged 5 commits intoAliceO2Group:devfrom Dec 14, 2023
Merged
Conversation
Contributor
|
Thanks a lot @nicolovalle for the very fast implementation! It looks fine to me since you set also the process name based on the detector. |
shahor02
reviewed
Dec 13, 2023
Collaborator
shahor02
left a comment
shahor02
left a comment
There was a problem hiding this comment.
Hi @nicolovalle
Please see 1 comment below (vectors of fixed size objects should be accessed as spans).
The rest looks fine assuming you tested the workflow.
One general comment is that inserting/erasing in std::set is a relatively expensive procedure, would be faster to use a simple vector. But given that you are processing 1 TF out of many this should also work
shahor02
approved these changes
Dec 13, 2023
Collaborator
shahor02
left a comment
shahor02
left a comment
There was a problem hiding this comment.
Thanks! Will merge once CI is passed.
chiarazampolli
pushed a commit
that referenced
this pull request
Dec 15, 2023
* ITS and MFT dead damp builder workflow * removing trailing spaces * removing unused struct * fixing format * optimization --------- Co-authored-by: Nicolo Valle <nicolo.valle@cern.ch>
andreasmolander
pushed a commit
to andreasmolander/AliceO2
that referenced
this pull request
Apr 12, 2024
* ITS and MFT dead damp builder workflow * removing trailing spaces * removing unused struct * fixing format * optimization --------- Co-authored-by: Nicolo Valle <nicolo.valle@cern.ch>
andreasmolander
pushed a commit
to andreasmolander/AliceO2
that referenced
this pull request
Apr 12, 2024
* ITS and MFT dead damp builder workflow * removing trailing spaces * removing unused struct * fixing format * optimization --------- Co-authored-by: Nicolo Valle <nicolo.valle@cern.ch>
mwinn2
pushed a commit
to mwinn2/AliceO2
that referenced
this pull request
Apr 25, 2024
* ITS and MFT dead damp builder workflow * removing trailing spaces * removing unused struct * fixing format * optimization --------- Co-authored-by: Nicolo Valle <nicolo.valle@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces #12442 and #12445
cc @shahor02 @mcoquet642 , @iravasen @IsakovAD