Switch off reading of BadChannel CCDB information in StatusMap Creator

[lmassacr]

Switch off the reading of BadChannel CCDB information in StatusMap Creator.
A protection will need to be developped in the code in case an Invalid Solar Id is read from the BadChannel CCDB information, before one can enable back this option in the MCH reconstruction.

[chiarazampolli]

Hello @lmassacr , @shahor02 , @TimoWilken ,

The CI is not starting, I think the MCH should approve first, right?

Cheers,

Chiara

[TimoWilken]

Hi @chiarazampolli, yes, someone in the team @AliceO2Group/muon-experts needs to approve this PR for the checks to start.

[shahor02]

conditionally approving to start CI

[lmassacr]

Hello @lmassacr , @shahor02 , @TimoWilken ,

The CI is not starting, I think the MCH should approve first, right?

Cheers,

Chiara

Hi Chiara @chiarazampolli,

Indeed, I need to ask to be added in the muon-expert list as replacement for Laurent. I don't have the approval rights yet.
I think Philippe or Andrea should have. I will ping them.
In parallel I am still looking into a solution with a patch of the CCDBs (we have a CCDB entry per calibration run in data, so this might explain why with the same code some period/runs are crashing and others not). We need to scan all the CCDB entries to identify the falty ones, also cross checking with the reported crashed jobs.

Cheers,
Laure

[shahor02]

Before I was able to force-approve, but does it not work anymore, even after adding myself as a codeowner. Indeed need to wait for somebody from the @AliceO2Group/muon-experts

[TimoWilken]

No you're right @shahor02, your approval seems to have worked -- some of the checks have started. Your are a repo admin, so you can always approve.

[pillot]

Hi @chiarazampolli, yes, someone in the team @AliceO2Group/muon-experts needs to approve this PR for the checks to start.

Hi @TimoWilken , just for my understanding, is it a new feature ? So far we were waiting for the checks to pass before approving the PR.

[pillot]

Just in case my approval is still a blocker, but I don't think so.

[alibuild]

Error while checking build/O2/fullCI for 4e82009 at 2024-01-13 17:24:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/QualityControl-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
command /sw/slc8_x86-64/O2/12511-slc8_x86-64-local1/prodtests/full-system-test/dpl-workflow.sh had nonzero exit code 128
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data HMP/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data FLP/DISTSUBTIMEFRAME/0 was not created for timeslice 0 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data MID/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data CTP/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data TOF/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data TPC/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data ITS/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data MFT/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data MCH/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data PHS/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data TRD/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data CPV/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data EMC/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data FDD/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data FT0/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data FV0/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data ZDC/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data FLP/DISTSUBTIMEFRAME/52443 was not created for timeslice 1 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data HMP/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data FLP/DISTSUBTIMEFRAME/0 was not created for timeslice 1 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data MID/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data CTP/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data TOF/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data TPC/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data ITS/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48473:raw-file-reader]: [16:23:55][ERROR] Expected Lifetime::Timeframe data MFT/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[0 more errors; see full log]

Full log here.

[chiarazampolli]

Hello @shahor02 ,
Can this be merged?
Chiara

[TimoWilken]

Hi @pillot, while this is not a new feature, this only applies to new contributors' first PRs. This is for security reasons, since the checks can run arbitrary user-supplied code.

Now that this is merged, all of @lmassacr's future PRs will not need approval for the checks to start!

[pillot]

Hi @pillot, while this is not a new feature, this only applies to new contributors' first PRs. This is for security reasons, since the checks can run arbitrary user-supplied code.

Now that this is merged, all of @lmassacr's future PRs will not need approval for the checks to start!

Ok, good to know, thanks for the explanations! :)