Skip to content

Data inspector#12523

Merged
ktf merged 24 commits intoAliceO2Group:devfrom
O2DataInspector:data-inspector-updated
Jan 28, 2024
Merged

Data inspector#12523
ktf merged 24 commits intoAliceO2Group:devfrom
O2DataInspector:data-inspector-updated

Conversation

@a-wolk
Copy link
Contributor

@a-wolk a-wolk commented Jan 13, 2024

@ktf
It is updated PR #10373 and it is prepared in form of a plugin. Can we run tests again?

  • adds endpoint configuration options
  • adds plugin which intercepts messages (send between devices) and sends their copies to outside server for debugging purposes
  • plugin communicates through simple TCP socket protocol

@a-wolk a-wolk requested a review from a team as a code owner January 13, 2024 13:58
@jotwinow
Copy link
Collaborator

@ktf @a-wolk @mrzelak

Dear Giulio,
Could you please have a look at this PR. It is a long standing Data Inspector project. I hope we can have it, use it in the tests.

Best regards,
Jacek

@ktf
Copy link
Member

ktf commented Jan 22, 2024

There are conflicts on the branch could you fix them?

@mrzelak
Copy link
Contributor

mrzelak commented Jan 22, 2024

@ktf conflict resolved

@a-wolk
Copy link
Contributor Author

a-wolk commented Jan 27, 2024

@ktf We have removed all changes in Core and started to use env variables.

@ktf
Copy link
Member

ktf commented Jan 28, 2024

Thanks. I have no further comments on the code. I assume you are good for me to squash all the commits into one. If yes, I will merge this once all the tests pass. If not, please make sure you reduce the number of commits yourself and update the PR.

@a-wolk
Copy link
Contributor Author

a-wolk commented Jan 28, 2024

@ktf Yes, we can squash them. I see that tests are still pending.

@ktf ktf self-requested a review January 28, 2024 15:57
@ktf
Copy link
Member

ktf commented Jan 28, 2024

Ah, right. You are a first time contributor. Should be ok now.

@ktf ktf merged commit 21d9cfa into AliceO2Group:dev Jan 28, 2024
@ktf
Copy link
Member

ktf commented Jan 28, 2024

Sorry I made a mess with this. Could you push again, please?

@a-wolk
Copy link
Contributor Author

a-wolk commented Jan 28, 2024

@ktf Should we open another PR?

@a-wolk a-wolk mentioned this pull request Jan 28, 2024
@ktf
Copy link
Member

ktf commented Jan 28, 2024

Yes, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants