Merged
Conversation
Place bodies of `if' statements inside braces in order to pass clang-tidy phase. Signed-off-by: Michał Grzelak <mchl.grzlk@gmail.com>
Collaborator
Member
|
There are conflicts on the branch could you fix them? |
Contributor
|
@ktf conflict resolved |
ktf
reviewed
Jan 22, 2024
Contributor
Author
|
@ktf We have removed all changes in Core and started to use env variables. |
Member
|
Thanks. I have no further comments on the code. I assume you are good for me to squash all the commits into one. If yes, I will merge this once all the tests pass. If not, please make sure you reduce the number of commits yourself and update the PR. |
Contributor
Author
|
@ktf Yes, we can squash them. I see that tests are still pending. |
ktf
approved these changes
Jan 28, 2024
Member
|
Ah, right. You are a first time contributor. Should be ok now. |
Member
|
Sorry I made a mess with this. Could you push again, please? |
Contributor
Author
|
@ktf Should we open another PR? |
Merged
Member
|
Yes, sorry about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ktf
It is updated PR #10373 and it is prepared in form of a plugin. Can we run tests again?