Do not presecal ITS reco in FST unless FST_PRESCALE_ITS defined by shahor02 · Pull Request #12528 · AliceO2Group/AliceO2

shahor02 · 2024-01-15T20:04:21Z

No description provided.

alibuild · 2024-01-15T21:47:54Z

Error while checking build/O2/fullCI for 0652d60 at 2024-01-15 22:47:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
command /sw/slc8_x86-64/O2/12528-slc8_x86-64-local1/prodtests/full-system-test/dpl-workflow.sh had nonzero exit code 128
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data HMP/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data FLP/DISTSUBTIMEFRAME/0 was not created for timeslice 0 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data MID/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data CTP/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data TOF/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data TPC/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data ITS/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data MFT/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data MCH/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data PHS/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data TRD/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data CPV/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data EMC/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data FDD/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data FT0/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data FV0/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data ZDC/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data FLP/DISTSUBTIMEFRAME/52443 was not created for timeslice 1 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data HMP/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data FLP/DISTSUBTIMEFRAME/0 was not created for timeslice 1 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data MID/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data CTP/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data TOF/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data TPC/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data ITS/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data MFT/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data MCH/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data PHS/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data TRD/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data CPV/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data EMC/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data FDD/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data FT0/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data FV0/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[71393:raw-file-reader]: [21:47:18][ERROR] Expected Lifetime::Timeframe data ZDC/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[71418:BadMapCalibSpec]: [21:47:36][ERROR] Insufficient statistics: 4 entries in lowE histo, do nothing
[71525:ctf-writer]: [21:47:41][ERROR] Some Lifetime::Timeframe data got dropped starting at 1
[ERROR] Workflow crashed - PID 71510 (tpc-calibrator-gainmap-tracks) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR]  - Device tpc-calibrator-gainmap-tracks: pid 71510 (exit 128)
[ERROR] SEVERE: Device tpc-calibrator-gainmap-tracks (71510) returned with 128
[0 more errors; see full log]

Full log here.

shahor02 · 2024-01-15T21:52:50Z

Detectors/ITSMFT/ITS/workflow/src/TrackerSpec.cxx

    trackParams[0].MinTrackLength = 4;
+    trackParams[0].CellsPerClusterLimit = 1.e2f;
+    trackParams[0].TrackletsPerClusterLimit = 1.e2f;
    LOG(info) << "Initializing tracker in sync. phase reconstruction with " << trackParams.size() << " passes";


@mconcas @mpuccio After suppressing ITS reco prescaling in the sync. mode of FST, I got a message

Too many tracklets per cluster (3.18), check the detector status and/or the selections. Current limit is 2.0

To avoid this, I am setting the thresholds to higher values, still 10 times less than in the async mode. Please confirm that this is ok.

@mconcas @mpuccio After suppressing ITS reco prescaling in the sync. mode of FST, I got a message

Too many tracklets per cluster (3.18), check the detector status and/or the selections. Current limit is 2.0

To avoid this, I am setting the thresholds to higher values, still 10 times less than in the async mode. Please confirm that this is ok.

Changing that value would change the production setting we have in place for sync mode.
We are probably going to be safe anyway because of the prescaler, but we could think of letting the default as it is and overriding the configuration in FST with the higher value.

mconcas · 2024-01-15T22:33:22Z

@shahor02 is something like the combination of the two suggestions below an option? I cannot test right now, sorry.

alibuild · 2024-01-15T22:33:41Z

Error while checking build/O2/fullCI for ac1eaf4 at 2024-01-16 09:36:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
command /sw/slc8_x86-64/O2/12528-slc8_x86-64-local1/prodtests/full-system-test/dpl-workflow.sh had nonzero exit code 128
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data HMP/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data FLP/DISTSUBTIMEFRAME/0 was not created for timeslice 0 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data MID/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data CTP/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data TOF/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data TPC/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data ITS/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data MFT/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data MCH/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data PHS/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data TRD/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data CPV/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data EMC/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data FDD/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data FT0/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data FV0/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data ZDC/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data FLP/DISTSUBTIMEFRAME/52443 was not created for timeslice 1 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data HMP/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data FLP/DISTSUBTIMEFRAME/0 was not created for timeslice 1 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data MID/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data CTP/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data TOF/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data TPC/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data ITS/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data MFT/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data MCH/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data PHS/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data TRD/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data CPV/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data EMC/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data FDD/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data FT0/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data FV0/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[72575:raw-file-reader]: [08:35:27][ERROR] Expected Lifetime::Timeframe data ZDC/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[72600:BadMapCalibSpec]: [08:35:46][ERROR] Insufficient statistics: 6 entries in lowE histo, do nothing
[72829:ctf-writer]: [08:35:50][ERROR] Some Lifetime::Timeframe data got dropped starting at 1
[ERROR] Workflow crashed - PID 72765 (tpc-calibrator-gainmap-tracks) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR]  - Device tpc-calibrator-gainmap-tracks: pid 72765 (exit 128)
[ERROR] SEVERE: Device tpc-calibrator-gainmap-tracks (72765) returned with 128
[0 more errors; see full log]

Full log here.

prodtests/full_system_test.sh

prodtests/full-system-test/dpl-workflow.sh

shahor02 · 2024-01-16T12:08:53Z

OK, I've moved increasing the thresholds to FST.

alibuild · 2024-01-16T14:04:38Z

Error while checking build/O2/fullCI for f0c5612 at 2024-01-16 15:04:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
command /sw/slc8_x86-64/O2/12528-slc8_x86-64-local1/prodtests/full-system-test/dpl-workflow.sh had nonzero exit code 128
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data HMP/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data FLP/DISTSUBTIMEFRAME/0 was not created for timeslice 0 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data MID/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data CTP/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data TOF/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data TPC/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data ITS/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data MFT/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data MCH/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data PHS/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data TRD/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data CPV/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data EMC/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data FDD/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data FT0/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data FV0/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data ZDC/RAWDATA was not created for timeslice 0 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data FLP/DISTSUBTIMEFRAME/52443 was not created for timeslice 1 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data HMP/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data FLP/DISTSUBTIMEFRAME/0 was not created for timeslice 1 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data MID/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data CTP/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data TOF/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data TPC/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data ITS/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data MFT/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data MCH/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data PHS/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data TRD/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data CPV/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data EMC/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data FDD/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data FT0/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data FV0/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48800:raw-file-reader]: [14:03:57][ERROR] Expected Lifetime::Timeframe data ZDC/RAWDATA was not created for timeslice 1 and might result in dropped timeframes
[48825:BadMapCalibSpec]: [14:04:24][ERROR] Insufficient statistics: 3 entries in lowE histo, do nothing
[48902:ctf-writer]: [14:04:26][ERROR] Some Lifetime::Timeframe data got dropped starting at 1
[ERROR] Workflow crashed - PID 48881 (tpc-calibrator-gainmap-tracks) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR]  - Device tpc-calibrator-gainmap-tracks: pid 48881 (exit 128)
[ERROR] SEVERE: Device tpc-calibrator-gainmap-tracks (48881) returned with 128
[0 more errors; see full log]

Full log here.

shahor02 · 2024-01-16T14:11:17Z

tested locally, merging

shahor02 requested a review from a team as a code owner January 15, 2024 20:04

shahor02 force-pushed the pr_fstNoPrescale branch from 0652d60 to ac1eaf4 Compare January 15, 2024 21:48

shahor02 requested a review from mconcas as a code owner January 15, 2024 21:48

shahor02 commented Jan 15, 2024

View reviewed changes

mconcas requested changes Jan 15, 2024

View reviewed changes

prodtests/full_system_test.sh Show resolved Hide resolved

prodtests/full-system-test/dpl-workflow.sh Show resolved Hide resolved

Do not prescale ITS reco in FST unless FST_PRESCALE_ITS defined

f0c5612

shahor02 force-pushed the pr_fstNoPrescale branch from ac1eaf4 to f0c5612 Compare January 16, 2024 12:07

mconcas approved these changes Jan 16, 2024

View reviewed changes

shahor02 merged commit 64c9e01 into AliceO2Group:dev Jan 16, 2024

shahor02 deleted the pr_fstNoPrescale branch January 16, 2024 14:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not presecal ITS reco in FST unless FST_PRESCALE_ITS defined#12528

Do not presecal ITS reco in FST unless FST_PRESCALE_ITS defined#12528
shahor02 merged 1 commit intoAliceO2Group:devfrom
shahor02:pr_fstNoPrescale

shahor02 commented Jan 15, 2024

Uh oh!

alibuild commented Jan 15, 2024

Uh oh!

shahor02 Jan 15, 2024

Uh oh!

mconcas Jan 15, 2024

Uh oh!

mconcas commented Jan 15, 2024 •

edited

Loading

Uh oh!

alibuild commented Jan 15, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

shahor02 commented Jan 16, 2024

Uh oh!

alibuild commented Jan 16, 2024

Uh oh!

shahor02 commented Jan 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Conversation

shahor02 commented Jan 15, 2024

Uh oh!

alibuild commented Jan 15, 2024

Uh oh!

shahor02 Jan 15, 2024

Choose a reason for hiding this comment

Uh oh!

mconcas Jan 15, 2024

Choose a reason for hiding this comment

Uh oh!

mconcas commented Jan 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Jan 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shahor02 commented Jan 16, 2024

Uh oh!

alibuild commented Jan 16, 2024

Uh oh!

shahor02 commented Jan 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

mconcas commented Jan 15, 2024 •

edited

Loading

alibuild commented Jan 15, 2024 •

edited

Loading