Skip to content

DPL: reduce helpers for makeHolder / makeHolderTypes#12656

Merged
ktf merged 1 commit intoAliceO2Group:devfrom
ktf:pr12656
Feb 6, 2024
Merged

DPL: reduce helpers for makeHolder / makeHolderTypes#12656
ktf merged 1 commit intoAliceO2Group:devfrom
ktf:pr12656

Conversation

@ktf
Copy link
Member

@ktf ktf commented Feb 5, 2024

DPL: reduce helpers for makeHolder / makeHolderTypes

C++20 allows simplifying the enumeration.

C++20 allows simplifying the enumeration.
@ktf ktf requested a review from a team as a code owner February 5, 2024 12:13
@alibuild
Copy link
Collaborator

alibuild commented Feb 6, 2024

Error while checking build/O2/fullCI for 0da3c1e at 2024-02-06 10:29:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
command alien-token-init had nonzero exit code 2


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/bbba6a11e7475a6e61f38357d3bc525726498ef5/slc8_x86-64/o2checkcode/1.0-local1533/etc/modulefiles
++ cat
--

Full log here.

@ktf ktf merged commit fdd0375 into AliceO2Group:dev Feb 6, 2024
@ktf
Copy link
Member Author

ktf commented Feb 6, 2024

Provides a bit of speedup and reduces unneeded complexity. Tested on hyperloop as well, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants