TPC: Improve allowed number of bins and custom binning options#12659
Merged
martenole merged 2 commits intoAliceO2Group:devfrom Feb 6, 2024
Merged
TPC: Improve allowed number of bins and custom binning options#12659martenole merged 2 commits intoAliceO2Group:devfrom
martenole merged 2 commits intoAliceO2Group:devfrom
Conversation
* Bin index was unsingend short limiting number of bins * Binning vector can now be - empty: use default uniform binning - single number: use number as number of bins for uniform binning - exact bin limits
martenole
approved these changes
Feb 5, 2024
| if (binning.size() == 0) { | ||
| LOGP(info, "Empty binning provided, will use default uniform y/x binning with {} bins", mNY2XBins); | ||
| return; | ||
| } else if (binning.size() == 1) { |
Contributor
There was a problem hiding this comment.
Fine with me, although in principle for uniform binning one can also call setNY2XBins before doing the initialization. But I see that this way will make it simpler to use the script with different binning settings.
| /// \param iz Bin index in Z/X | ||
| /// \return global bin number | ||
| unsigned short getGlbVoxBin(int ix, int ip, int iz) const; | ||
| size_t getGlbVoxBin(int ix, int ip, int iz) const; |
Contributor
There was a problem hiding this comment.
unsigned int should have been sufficient, but I doubt that it has an impact to stay with size_t
Collaborator
Author
|
Can this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.