Skip to content

Set bits in the AO2D track mc mask according to documentation#12750

Closed
mpuccio wants to merge 1 commit intoAliceO2Group:devfrom
mpuccio:dev
Closed

Set bits in the AO2D track mc mask according to documentation#12750
mpuccio wants to merge 1 commit intoAliceO2Group:devfrom
mpuccio:dev

Conversation

@mpuccio
Copy link
Contributor

@mpuccio mpuccio commented Feb 23, 2024

  • Set bits in the track mc mask according to documentation
    According to the documentation, bit 11 of the AO2D mc mask for the tracks should be reserved for TOF fake matches, and bit 15 should be used for the fake. This was brought up by @wang-yuanzhe and @fmazzasc while checking for TOF fake matches. @noferini @shahor02, does this make sense to you? @ddobrigk might also be interested as it changes the meaning of a bit in the AO2D.

@mpuccio mpuccio requested a review from a team as a code owner February 23, 2024 09:34
@noferini
Copy link
Collaborator

Hi @mpuccio , the logic seems fine and consistent with the documentation you linked. But I didn't follow the set of this bit mask so @ddobrigk can then comment better than me.

@shahor02
Copy link
Collaborator

@mpuccio fine for me but I don't really understand this documentation on the mcMask, particularly the ITS and TPC part.
I see that the TRD part (bit 10) is not set at all while the bit 15 (negative label) is redundant: the negative label (isFake) of the particular track means that the last detector update added an object with MC truth ID different from the seed. This info is already supposed to be provided by other bits.

@mpuccio
Copy link
Contributor Author

mpuccio commented Feb 23, 2024

Hi @shahor02, I agree with you, if you prefer and @ddobrigk agrees I can modify the code and add the remaining bits.

@alibuild
Copy link
Collaborator

alibuild commented Feb 23, 2024

Error while checking build/O2/fullCI for e822fbf at 2024-02-24 10:59:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
task timeout reached .. killing all processes


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/e7c4b379583dd0a961aa89b8322cba94fc2dc06b/slc8_x86-64/o2checkcode/1.0-local112/etc/modulefiles
++ cat
--

Full log here.

@ddobrigk
Copy link
Contributor

Thanks a lot @mpuccio, please go ahead! BTW would it perhaps also make sense to define these bits in enums somewhere?

@github-actions
Copy link
Contributor

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

@github-actions github-actions bot added the stale label Mar 26, 2024
@github-actions github-actions bot closed this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants