Set bits in the AO2D track mc mask according to documentation#12750
Closed
mpuccio wants to merge 1 commit intoAliceO2Group:devfrom
Closed
Set bits in the AO2D track mc mask according to documentation#12750mpuccio wants to merge 1 commit intoAliceO2Group:devfrom
mpuccio wants to merge 1 commit intoAliceO2Group:devfrom
Conversation
Collaborator
Collaborator
|
@mpuccio fine for me but I don't really understand this documentation on the mcMask, particularly the ITS and TPC part. |
Contributor
Author
Collaborator
|
Error while checking build/O2/fullCI for e822fbf at 2024-02-24 10:59: Full log here. |
Contributor
|
Thanks a lot @mpuccio, please go ahead! BTW would it perhaps also make sense to define these bits in enums somewhere? |
Contributor
|
This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the documentation, bit 11 of the AO2D mc mask for the tracks should be reserved for TOF fake matches, and bit 15 should be used for the fake. This was brought up by @wang-yuanzhe and @fmazzasc while checking for TOF fake matches. @noferini @shahor02, does this make sense to you? @ddobrigk might also be interested as it changes the meaning of a bit in the AO2D.