Skip to content

DPL: drop special policy for Dispatcher#12788

Merged
davidrohr merged 2 commits intoAliceO2Group:devfrom
ktf:pr12788
Mar 4, 2024
Merged

DPL: drop special policy for Dispatcher#12788
davidrohr merged 2 commits intoAliceO2Group:devfrom
ktf:pr12788

Conversation

@ktf
Copy link
Member

@ktf ktf commented Mar 1, 2024

ktf added 2 commits March 1, 2024 09:32
I suspect what is happening in the test is the consumers start
too late (and the lossy policy drops messages on the sender side
when that happens).

This should avoid the problem by increasing the delay up to 1 second,
before switching to lossy, giving enough time to the consumers to start.
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

@ktf
Copy link
Member Author

ktf commented Mar 1, 2024

@Barthelemy @knopers8 @davidrohr but then again, do we need at all a special policy for the dispatcher? Isn't it enough to make the dispatcher non-lossy if the task after it is not expendable (i.e. the default policy) and lossy if it is?

@davidrohr
Copy link
Collaborator

@Barthelemy @knopers8 @davidrohr but then again, do we need at all a special policy for the dispatcher? Isn't it enough to make the dispatcher non-lossy if the task after it is not expendable (i.e. the default policy) and lossy if it is?

seems plausible to me

@knopers8
Copy link
Collaborator

knopers8 commented Mar 1, 2024

Yes, I think so.

@davidrohr davidrohr merged commit 3922251 into AliceO2Group:dev Mar 4, 2024
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
* DPL: attempt to have some dropping logic which does not break test

I suspect what is happening in the test is the consumers start
too late (and the lossy policy drops messages on the sender side
when that happens).

This should avoid the problem by increasing the delay up to 1 second,
before switching to lossy, giving enough time to the consumers to start.

* DPL: drop special policy for Dispatcher
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
* DPL: attempt to have some dropping logic which does not break test

I suspect what is happening in the test is the consumers start
too late (and the lossy policy drops messages on the sender side
when that happens).

This should avoid the problem by increasing the delay up to 1 second,
before switching to lossy, giving enough time to the consumers to start.

* DPL: drop special policy for Dispatcher
mwinn2 pushed a commit to mwinn2/AliceO2 that referenced this pull request Apr 25, 2024
* DPL: attempt to have some dropping logic which does not break test

I suspect what is happening in the test is the consumers start
too late (and the lossy policy drops messages on the sender side
when that happens).

This should avoid the problem by increasing the delay up to 1 second,
before switching to lossy, giving enough time to the consumers to start.

* DPL: drop special policy for Dispatcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants