Skip to content

Ctpdev: ctpRateFetcher#12791

Merged
shahor02 merged 8 commits intoAliceO2Group:devfrom
lietava:ctpdev
Mar 5, 2024
Merged

Ctpdev: ctpRateFetcher#12791
shahor02 merged 8 commits intoAliceO2Group:devfrom
lietava:ctpdev

Conversation

@lietava
Copy link
Contributor

@lietava lietava commented Mar 1, 2024

  • copy of O2Physics ctpRateFetcher created in as purse macro in O2
  • bug in CTPScalers fixed
  • warning in CTPScalers removed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

@lietava lietava marked this pull request as ready for review March 1, 2024 17:32
@lietava lietava requested a review from a team as a code owner March 1, 2024 17:32
@mpuccio
Copy link
Contributor

mpuccio commented Mar 4, 2024

@lietava, in O2 it is not possible to include O2Physics classes, we should modify the macro to avoid this dependency

mpuccio
mpuccio reviewed Mar 4, 2024
View reviewed changes
Detectors/CTP/macro/GetScalersForRun.C
#include <DataFormatsCTP/Configuration.h>
#include "ctpRateFetcher.h"
#include <DataFormatsParameters/GRPLHCIFData.h>
#include "Common/CCDB/ctpRateFetcher.h"
Copy link
Contributor

@mpuccio mpuccio Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should guard this and the places where we use ctpRateFetcher with a #ifdef or we should move the full macro to O2Physics

@lietava
Copy link
Contributor Author

lietava commented Mar 5, 2024

Please, merge.

@shahor02 shahor02 merged commit 4c82740 into AliceO2Group:dev Mar 5, 2024
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
@lietava @andreasmolander
Ctpdev: ctpRateFetcher (AliceO2Group#12791)
2211f89 
* dev:debuging ctpRateFetcher

* clang

* fixes

* clang

* fixes

* ctpRateF.C moved to O2Physics

* clang

* fix
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
@lietava @andreasmolander
Ctpdev: ctpRateFetcher (AliceO2Group#12791)
c1cdf6f 
* dev:debuging ctpRateFetcher

* clang

* fixes

* clang

* fixes

* ctpRateF.C moved to O2Physics

* clang

* fix
mwinn2 pushed a commit to mwinn2/AliceO2 that referenced this pull request Apr 25, 2024
@lietava @mwinn2
Ctpdev: ctpRateFetcher (AliceO2Group#12791)
ea6b7c9 
* dev:debuging ctpRateFetcher

* clang

* fixes

* clang

* fixes

* ctpRateF.C moved to O2Physics

* clang

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mpuccio mpuccio mpuccio left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lietava @mpuccio @shahor02