Skip to content

[EMCAL-565] Add check to mask entire SM/FEC if a certain fraction is masked#12808

Merged
mfasDa merged 1 commit intoAliceO2Group:devfrom
jokonig:EMCAL-565
Mar 15, 2024
Merged

[EMCAL-565] Add check to mask entire SM/FEC if a certain fraction is masked#12808
mfasDa merged 1 commit intoAliceO2Group:devfrom
jokonig:EMCAL-565

Conversation

@jokonig
Copy link
Collaborator

@jokonig jokonig commented Mar 5, 2024

  • In a few runs in the 2022 and 2023 data taking, a low energetic noise was present in some SMs. This low-energetic noise was however not affecting all cells equally, leading to weird distributions in the number of bad channels within the SMs (more than 50+% of the SM were masked). For more details see: https://indico.cern.ch/event/1387104/contributions/5830894/subcontributions/468897/attachments/2806947/4898041/2024_02_23.pdf
  • Now, a check is implemented to check the fraction of bad+dead cells within a SM. If this fraction exceeds a certain value (set to 50% by default but can be changed via the CalibParams), the whole SM is masked.
  • Analogous, this was implemented per FEC. Here the default value was set to 90% in order to not overmask. This value still has to be properly tuned
  • The effect on the runtime of the calibration was found to be negligible

…masked

- In a few runs in the 2022 and 2023 data taking, a low energetic noise was present in some SMs. This low-energetic noise was however not affecting all cells equally, leading to weird distributions in the number of bad channels within the SMs (more than 50+% of the SM were masked). For more details see: https://indico.cern.ch/event/1387104/contributions/5830894/subcontributions/468897/attachments/2806947/4898041/2024_02_23.pdf
- Now, a check is implemented to check the fraction of bad+dead cells within a SM. If this fraction exceeds a certain value (set to 50% by degault but can be changed via the CalibParams), the whole SM is masked.
- Analogous, this was implemented per FEC. Here the default value was set to 90% in order to not overmask. THis value still has to be properly tuned
- The effect on the runtime of the calibration was found to be negligible
@jokonig jokonig requested a review from mfasDa as a code owner March 5, 2024 09:56
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

@alibuild
Copy link
Collaborator

alibuild commented Mar 7, 2024

Error while checking build/O2/fullCI for 1fb93b0 at 2024-03-07 05:27:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
command o2-sim --seed 12345 -j 32 -n 100 -m PIPE ITS MFT FT0 FV0 FDD -g extgen -e TGeant4 --configKeyValues "GeneratorExternal.fileName=$O2_ROOT/share/Generators/external/QEDLoader.C;QEDGenParam.yMin=-7;QEDGenParam.yMax=7;QEDGenParam.ptMin=0.001;QEDGenParam.ptMax=1.;${SIMOPTKEY}" --run 310000 had nonzero exit code 134
[FATAL] Empty, missing or invalid response from query to RCT/Info/RunInformation for run 310000


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/8432095927a2b525c5c3bd5d8c77012b83e5ff02/slc8_x86-64/o2checkcode/1.0-local1404/etc/modulefiles
++ cat
--

Full log here.

Copy link
Collaborator

@mfasDa mfasDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good and can be merged. Please add some comment on the relevant ticket.

@mfasDa mfasDa enabled auto-merge (squash) March 13, 2024 15:44
@mfasDa mfasDa merged commit f20fb0c into AliceO2Group:dev Mar 15, 2024
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
…masked (AliceO2Group#12808)

- In a few runs in the 2022 and 2023 data taking, a low energetic noise was present in some SMs. This low-energetic noise was however not affecting all cells equally, leading to weird distributions in the number of bad channels within the SMs (more than 50+% of the SM were masked). For more details see: https://indico.cern.ch/event/1387104/contributions/5830894/subcontributions/468897/attachments/2806947/4898041/2024_02_23.pdf
- Now, a check is implemented to check the fraction of bad+dead cells within a SM. If this fraction exceeds a certain value (set to 50% by degault but can be changed via the CalibParams), the whole SM is masked.
- Analogous, this was implemented per FEC. Here the default value was set to 90% in order to not overmask. THis value still has to be properly tuned
- The effect on the runtime of the calibration was found to be negligible

Co-authored-by: jokonig <jokonig@cern.ch>
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
…masked (AliceO2Group#12808)

- In a few runs in the 2022 and 2023 data taking, a low energetic noise was present in some SMs. This low-energetic noise was however not affecting all cells equally, leading to weird distributions in the number of bad channels within the SMs (more than 50+% of the SM were masked). For more details see: https://indico.cern.ch/event/1387104/contributions/5830894/subcontributions/468897/attachments/2806947/4898041/2024_02_23.pdf
- Now, a check is implemented to check the fraction of bad+dead cells within a SM. If this fraction exceeds a certain value (set to 50% by degault but can be changed via the CalibParams), the whole SM is masked.
- Analogous, this was implemented per FEC. Here the default value was set to 90% in order to not overmask. THis value still has to be properly tuned
- The effect on the runtime of the calibration was found to be negligible

Co-authored-by: jokonig <jokonig@cern.ch>
mwinn2 pushed a commit to mwinn2/AliceO2 that referenced this pull request Apr 25, 2024
…masked (AliceO2Group#12808)

- In a few runs in the 2022 and 2023 data taking, a low energetic noise was present in some SMs. This low-energetic noise was however not affecting all cells equally, leading to weird distributions in the number of bad channels within the SMs (more than 50+% of the SM were masked). For more details see: https://indico.cern.ch/event/1387104/contributions/5830894/subcontributions/468897/attachments/2806947/4898041/2024_02_23.pdf
- Now, a check is implemented to check the fraction of bad+dead cells within a SM. If this fraction exceeds a certain value (set to 50% by degault but can be changed via the CalibParams), the whole SM is masked.
- Analogous, this was implemented per FEC. Here the default value was set to 90% in order to not overmask. THis value still has to be properly tuned
- The effect on the runtime of the calibration was found to be negligible

Co-authored-by: jokonig <jokonig@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants