[EMCAL-565] Add check to mask entire SM/FEC if a certain fraction is masked#12808
Merged
mfasDa merged 1 commit intoAliceO2Group:devfrom Mar 15, 2024
Merged
[EMCAL-565] Add check to mask entire SM/FEC if a certain fraction is masked#12808mfasDa merged 1 commit intoAliceO2Group:devfrom
mfasDa merged 1 commit intoAliceO2Group:devfrom
Conversation
Collaborator
jokonig
commented
Mar 5, 2024
- In a few runs in the 2022 and 2023 data taking, a low energetic noise was present in some SMs. This low-energetic noise was however not affecting all cells equally, leading to weird distributions in the number of bad channels within the SMs (more than 50+% of the SM were masked). For more details see: https://indico.cern.ch/event/1387104/contributions/5830894/subcontributions/468897/attachments/2806947/4898041/2024_02_23.pdf
- Now, a check is implemented to check the fraction of bad+dead cells within a SM. If this fraction exceeds a certain value (set to 50% by default but can be changed via the CalibParams), the whole SM is masked.
- Analogous, this was implemented per FEC. Here the default value was set to 90% in order to not overmask. This value still has to be properly tuned
- The effect on the runtime of the calibration was found to be negligible
…masked - In a few runs in the 2022 and 2023 data taking, a low energetic noise was present in some SMs. This low-energetic noise was however not affecting all cells equally, leading to weird distributions in the number of bad channels within the SMs (more than 50+% of the SM were masked). For more details see: https://indico.cern.ch/event/1387104/contributions/5830894/subcontributions/468897/attachments/2806947/4898041/2024_02_23.pdf - Now, a check is implemented to check the fraction of bad+dead cells within a SM. If this fraction exceeds a certain value (set to 50% by degault but can be changed via the CalibParams), the whole SM is masked. - Analogous, this was implemented per FEC. Here the default value was set to 90% in order to not overmask. THis value still has to be properly tuned - The effect on the runtime of the calibration was found to be negligible
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Collaborator
|
Error while checking build/O2/fullCI for 1fb93b0 at 2024-03-07 05:27: Full log here. |
mfasDa
approved these changes
Mar 13, 2024
Collaborator
mfasDa
left a comment
There was a problem hiding this comment.
In general looks good and can be merged. Please add some comment on the relevant ticket.
andreasmolander
pushed a commit
to andreasmolander/AliceO2
that referenced
this pull request
Apr 12, 2024
…masked (AliceO2Group#12808) - In a few runs in the 2022 and 2023 data taking, a low energetic noise was present in some SMs. This low-energetic noise was however not affecting all cells equally, leading to weird distributions in the number of bad channels within the SMs (more than 50+% of the SM were masked). For more details see: https://indico.cern.ch/event/1387104/contributions/5830894/subcontributions/468897/attachments/2806947/4898041/2024_02_23.pdf - Now, a check is implemented to check the fraction of bad+dead cells within a SM. If this fraction exceeds a certain value (set to 50% by degault but can be changed via the CalibParams), the whole SM is masked. - Analogous, this was implemented per FEC. Here the default value was set to 90% in order to not overmask. THis value still has to be properly tuned - The effect on the runtime of the calibration was found to be negligible Co-authored-by: jokonig <jokonig@cern.ch>
andreasmolander
pushed a commit
to andreasmolander/AliceO2
that referenced
this pull request
Apr 12, 2024
…masked (AliceO2Group#12808) - In a few runs in the 2022 and 2023 data taking, a low energetic noise was present in some SMs. This low-energetic noise was however not affecting all cells equally, leading to weird distributions in the number of bad channels within the SMs (more than 50+% of the SM were masked). For more details see: https://indico.cern.ch/event/1387104/contributions/5830894/subcontributions/468897/attachments/2806947/4898041/2024_02_23.pdf - Now, a check is implemented to check the fraction of bad+dead cells within a SM. If this fraction exceeds a certain value (set to 50% by degault but can be changed via the CalibParams), the whole SM is masked. - Analogous, this was implemented per FEC. Here the default value was set to 90% in order to not overmask. THis value still has to be properly tuned - The effect on the runtime of the calibration was found to be negligible Co-authored-by: jokonig <jokonig@cern.ch>
mwinn2
pushed a commit
to mwinn2/AliceO2
that referenced
this pull request
Apr 25, 2024
…masked (AliceO2Group#12808) - In a few runs in the 2022 and 2023 data taking, a low energetic noise was present in some SMs. This low-energetic noise was however not affecting all cells equally, leading to weird distributions in the number of bad channels within the SMs (more than 50+% of the SM were masked). For more details see: https://indico.cern.ch/event/1387104/contributions/5830894/subcontributions/468897/attachments/2806947/4898041/2024_02_23.pdf - Now, a check is implemented to check the fraction of bad+dead cells within a SM. If this fraction exceeds a certain value (set to 50% by degault but can be changed via the CalibParams), the whole SM is masked. - Analogous, this was implemented per FEC. Here the default value was set to 90% in order to not overmask. THis value still has to be properly tuned - The effect on the runtime of the calibration was found to be negligible Co-authored-by: jokonig <jokonig@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.