Skip to content

ctpdev: raw decoder output size protection #12830

Merged
shahor02 merged 2 commits intoAliceO2Group:devfrom
lietava:ctpdev
Mar 8, 2024
Merged

ctpdev: raw decoder output size protection #12830
shahor02 merged 2 commits intoAliceO2Group:devfrom
lietava:ctpdev

Conversation

@lietava
Copy link
Contributor

@lietava lietava commented Mar 7, 2024

I put protection size as parameter which can be tuned on data.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

@lietava
Copy link
Contributor Author

lietava commented Mar 7, 2024

HI @shahor02 , I added protection as parameter so I can tune it with data and can be fully swicthed off. Please, let me know your comments.

@shahor02
Copy link
Collaborator

shahor02 commented Mar 7, 2024

@lietava I thought you wanted to cut on the raw data size before decoding. But this also looks fine.
At the moment you just log an error, I guess you should count a certain number of consecutive TFs with this error and then produce Fatal?

@lietava
Copy link
Contributor Author

lietava commented Mar 7, 2024

@shahor02 : thanks. Yes, one can cut also on raw input. Anyway I would start like this - just one frame maybe enough for 40 mhz ringing - and test with raw or directly in P2.

@lietava lietava marked this pull request as ready for review March 7, 2024 16:18
@lietava lietava requested a review from a team as a code owner March 7, 2024 16:18
@lietava
Copy link
Contributor Author

lietava commented Mar 8, 2024

PLease, merge

@shahor02 shahor02 merged commit 94de37b into AliceO2Group:dev Mar 8, 2024
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
* dev: output size protection in ctp reco

* clang
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
* dev: output size protection in ctp reco

* clang
mwinn2 pushed a commit to mwinn2/AliceO2 that referenced this pull request Apr 25, 2024
* dev: output size protection in ctp reco

* clang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants