Skip to content

Ctpdev#12901

Merged
shahor02 merged 4 commits intoAliceO2Group:devfrom
lietava:ctpdev
Mar 21, 2024
Merged

Ctpdev#12901
shahor02 merged 4 commits intoAliceO2Group:devfrom
lietava:ctpdev

Conversation

@lietava
Copy link
Contributor

@lietava lietava commented Mar 21, 2024

1 resetorbit timestamp - milisec => microsec
2 raw decoder checking input size optimised - if maxinputsize == 0 check fully skipped.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

@lietava lietava marked this pull request as ready for review March 21, 2024 08:57
@lietava lietava requested a review from a team as a code owner March 21, 2024 08:57
sawenzel
sawenzel reviewed Mar 21, 2024
View reviewed changes
Detectors/CTP/workflowScalers/src/ctp-ccdb-orbit.cxx
std::vector<int64_t> vect;
std::string ccdbPath;
auto now = std::chrono::system_clock::now();
long tt = std::chrono::duration_cast<std::chrono::milliseconds>(now.time_since_epoch()).count();
Copy link
Collaborator

@sawenzel sawenzel Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a internal change of unit or will it effect information in CCDB objects?

Copy link
Contributor Author

@lietava lietava Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is to be change of the ccdb object content. Now after fix (second commit) it should be ok.

@alibuild
Copy link
Collaborator

alibuild commented Mar 21, 2024

Error while checking build/O2/fullCI for 96ac879 at 2024-03-21 15:44:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
task timeout reached .. killing all processes


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep ' error:'
++ grep -v clang-diagnostic-error error-log.txt
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/2597da7f736ab2208f579619dbfe9a1a66f0d8cd/slc8_x86-64/o2checkcode/1.0-local258/etc/modulefiles
++ cat
--

Full log here.

@lietava
Copy link
Contributor Author

lietava commented Mar 21, 2024

@sawenzel @shahor02 : as far as I can see there are no CTP related errors. If so, please, merge.

@shahor02 shahor02 merged commit 54e047e into AliceO2Group:dev Mar 21, 2024
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
@lietava @andreasmolander
Ctpdev (AliceO2Group#12901)
b2cc5d4 
* fixes

* clang

* fix

* clang
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
@lietava @andreasmolander
Ctpdev (AliceO2Group#12901)
2c80497 
* fixes

* clang

* fix

* clang
mwinn2 pushed a commit to mwinn2/AliceO2 that referenced this pull request Apr 25, 2024
@lietava @mwinn2
Ctpdev (AliceO2Group#12901)
0927319 
* fixes

* clang

* fix

* clang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sawenzel sawenzel sawenzel left review comments

@shahor02 shahor02 shahor02 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lietava @alibuild @sawenzel @shahor02