Skip to content

GPU HIP CMake: More fixes for ROCm detection, wasn't working on my laptop#12910

Merged
davidrohr merged 1 commit intoAliceO2Group:devfrom
davidrohr:dev_pull_request2
Mar 22, 2024
Merged

GPU HIP CMake: More fixes for ROCm detection, wasn't working on my laptop#12910
davidrohr merged 1 commit intoAliceO2Group:devfrom
davidrohr:dev_pull_request2

Conversation

@davidrohr
Copy link
Collaborator

In the end, something is wrong if the CMAKE_PREFIX_PATH does not contain the ROCm folder in the env variable.
Not fully sure where it breaks, if inside CMake or inside the ROCm CMake files.
However, setting CMAKE_PREFIX_PATH as default inside the O2 CMake just leads to partially broken behavior where some parts are not found. No idea how to fix it.
Thus we change strategy:

  • Check if CMAKE_PREFIX_PATH env variable is set and contains a ROCm path.
  • If not, disable ROCm. If ROCm is required, fail the build.
  • Derive all other ROCm paths from that PREFIX_PATH.

@davidrohr davidrohr requested a review from a team as a code owner March 21, 2024 23:26
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

@davidrohr davidrohr merged commit c280308 into AliceO2Group:dev Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant