GPU HIP CMake: More fixes for ROCm detection, wasn't working on my laptop#12910
Merged
davidrohr merged 1 commit intoAliceO2Group:devfrom Mar 22, 2024
Merged
GPU HIP CMake: More fixes for ROCm detection, wasn't working on my laptop#12910davidrohr merged 1 commit intoAliceO2Group:devfrom
davidrohr merged 1 commit intoAliceO2Group:devfrom
Conversation
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the end, something is wrong if the CMAKE_PREFIX_PATH does not contain the ROCm folder in the env variable.
Not fully sure where it breaks, if inside CMake or inside the ROCm CMake files.
However, setting CMAKE_PREFIX_PATH as default inside the O2 CMake just leads to partially broken behavior where some parts are not found. No idea how to fix it.
Thus we change strategy: