Skip to content

ITS GPU: INVALID_TRIGGER_ERROR_NO_HOST_CODE should not be defined away but GPUg() should only be used in GPUCode#12948

Merged
davidrohr merged 1 commit intoAliceO2Group:devfrom
davidrohr:dev_pull_request4
Mar 28, 2024
Merged

ITS GPU: INVALID_TRIGGER_ERROR_NO_HOST_CODE should not be defined away but GPUg() should only be used in GPUCode#12948
davidrohr merged 1 commit intoAliceO2Group:devfrom
davidrohr:dev_pull_request4

Conversation

@davidrohr
Copy link
Collaborator

@mconcas : GPUg() is a gpu keyword, not to be used in host code. Defining it away actually creates ambigious symbols: The host code will assume it is a normal CPU function, while it is in fact compiled as a GPU kernel.

I agree that there might be a use case to have the same function available as GPU-kernel and per thread on the CPU. But I think in that case, it is better to just wrap it in a kernel. Overall, I think we should not define INVALID_TRIGGER_ERROR_NO_HOST_CODE away, but it is a genuine error, and we should hide the kernel definitions in host code which does not understand it.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

@davidrohr davidrohr merged commit 3d7db22 into AliceO2Group:dev Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant