ITS GPU: INVALID_TRIGGER_ERROR_NO_HOST_CODE should not be defined away but GPUg() should only be used in GPUCode#12948
Merged
davidrohr merged 1 commit intoAliceO2Group:devfrom Mar 28, 2024
Conversation
…y but GPUg() should only be used in GPUCode
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mconcas :
GPUg()is a gpu keyword, not to be used in host code. Defining it away actually creates ambigious symbols: The host code will assume it is a normal CPU function, while it is in fact compiled as a GPU kernel.I agree that there might be a use case to have the same function available as GPU-kernel and per thread on the CPU. But I think in that case, it is better to just wrap it in a kernel. Overall, I think we should not define
INVALID_TRIGGER_ERROR_NO_HOST_CODEaway, but it is a genuine error, and we should hide the kernel definitions in host code which does not understand it.