Skip to content

ITSMFT: check on strobe length for STFDecoder#12952

Merged
shahor02 merged 7 commits intoAliceO2Group:devfrom
IsakovAD:IsakovAD_ITSMFT_strobeLengthCheck
Apr 11, 2024
Merged

ITSMFT: check on strobe length for STFDecoder#12952
shahor02 merged 7 commits intoAliceO2Group:devfrom
IsakovAD:IsakovAD_ITSMFT_strobeLengthCheck

Conversation

@IsakovAD
Copy link

Added check on the number of ROF per TF for ITS and MFT decoders.

Here the strobe length from parameters (ECS env or CCDB) is compared with number of triggers from Decoder.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

shahor02
shahor02 previously approved these changes Mar 30, 2024
mconcas
mconcas previously approved these changes Apr 8, 2024
@IsakovAD IsakovAD changed the title [WIP] ITSMFT: check on strobe length for STFDecoder ITSMFT: check on strobe length for STFDecoder Apr 9, 2024
@IsakovAD
Copy link
Author

IsakovAD commented Apr 9, 2024

@shahor02 could you please check the PR? I implemented your suggestions

shahor02
shahor02 previously approved these changes Apr 9, 2024
@alibuild
Copy link
Collaborator

alibuild commented Apr 9, 2024

Error while checking build/O2/fullCI for 7b25d31 at 2024-04-09 18:53:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/12952-slc8_x86-64/0/Detectors/ITSMFT/common/workflow/src/STFDecoderSpec.cxx:191:92: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@shahor02
Copy link
Collaborator

shahor02 commented Apr 9, 2024

@IsakovAD the fullCI error is genuine, could you please fix it:

/sw/SOURCES/O2/12952-slc8_x86-64/0/Detectors/ITSMFT/common/workflow/src/STFDecoderSpec.cxx:191:92: error: statement should be inside braces [readability-braces-around-statements]

@IsakovAD IsakovAD dismissed stale reviews from shahor02 and mconcas via 6cc5737 April 10, 2024 10:07
@IsakovAD
Copy link
Author

@shahor02 clang issue is fixed

mconcas
mconcas previously approved these changes Apr 10, 2024
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 6cc5737 at 2024-04-10 17:00:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/12952-slc8_x86-64/0/Detectors/ITSMFT/common/workflow/src/STFDecoderSpec.cxx:191:96: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@shahor02
Copy link
Collaborator

@IsakovAD the problem was in the {} missing around the 1-liner if, not () inside the if condition. Anyway, I've fixed it.

@shahor02 shahor02 merged commit f23fabe into AliceO2Group:dev Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants