[EMCAL-1116] Add maximum value for pedestal calib#12958
Merged
mfasDa merged 1 commit intoAliceO2Group:devfrom Apr 3, 2024
Merged
[EMCAL-1116] Add maximum value for pedestal calib#12958mfasDa merged 1 commit intoAliceO2Group:devfrom
mfasDa merged 1 commit intoAliceO2Group:devfrom
Conversation
Collaborator
jokonig
commented
Mar 29, 2024
jokonig
commented
- In order to not set unreasonable values for the pedestal calibration, a maximum value is introduced
- The value is configurable in the CalibrationParams
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
mfasDa
requested changes
Apr 2, 2024
Collaborator
mfasDa
left a comment
mfasDa
left a comment
There was a problem hiding this comment.
Needs some change: The default value first needs to be 1023 (10 bit, all bits 1), as the ADC works with 10 bit precision. Second, how can 10-bit ADC values exceed the 1023? The maximum ADC value (1023) should be set in case the RMS of the distribution (settable cut) is too high, effectively setting the channel to dead.
mfasDa
requested changes
Apr 2, 2024
Detectors/EMCAL/calibration/include/EMCALCalibration/EMCALCalibExtractor.h
Outdated
Show resolved
Hide resolved
- In order to not use unreasaonable data for the pedestal extraction, the RMS for each cell is compared against a Maximum. If the RMS is larger, the channel is set to 1023 which essentially masks the channel - The maximum value is configurable in the CalibrationParams
andreasmolander
pushed a commit
to andreasmolander/AliceO2
that referenced
this pull request
Apr 12, 2024
…p#12958) - In order to not use unreasaonable data for the pedestal extraction, the RMS for each cell is compared against a Maximum. If the RMS is larger, the channel is set to 1023 which essentially masks the channel - The maximum value is configurable in the CalibrationParams Co-authored-by: jokonig <jokonig@cern.ch>
andreasmolander
pushed a commit
to andreasmolander/AliceO2
that referenced
this pull request
Apr 12, 2024
…p#12958) - In order to not use unreasaonable data for the pedestal extraction, the RMS for each cell is compared against a Maximum. If the RMS is larger, the channel is set to 1023 which essentially masks the channel - The maximum value is configurable in the CalibrationParams Co-authored-by: jokonig <jokonig@cern.ch>
mwinn2
pushed a commit
to mwinn2/AliceO2
that referenced
this pull request
Apr 25, 2024
…p#12958) - In order to not use unreasaonable data for the pedestal extraction, the RMS for each cell is compared against a Maximum. If the RMS is larger, the channel is set to 1023 which essentially masks the channel - The maximum value is configurable in the CalibrationParams Co-authored-by: jokonig <jokonig@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.