Skip to content

[EMCAL-1116] Add possibility to push pedestals to DCS ccdb#12971

Merged
mfasDa merged 1 commit intoAliceO2Group:devfrom
jokonig:EMCAL-1116a
Apr 3, 2024
Merged

[EMCAL-1116] Add possibility to push pedestals to DCS ccdb#12971
mfasDa merged 1 commit intoAliceO2Group:devfrom
jokonig:EMCAL-1116a

Conversation

@jokonig
Copy link
Collaborator

@jokonig jokonig commented Apr 2, 2024

  • data to dcs ccdb has to be a vector
  • PedestalData is encoded as a string (in EMCALPedestalHelper)

@jokonig jokonig requested a review from mfasDa as a code owner April 2, 2024 14:31
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

@jokonig jokonig force-pushed the EMCAL-1116a branch 2 times, most recently from 6eed0e7 to e02cd4e Compare April 2, 2024 15:47
@jokonig jokonig changed the title [WIP] [EMCAL-1116] Add possibility to push pedestals to DCS ccdb [EMCAL-1116] Add possibility to push pedestals to DCS ccdb Apr 2, 2024
@alibuild
Copy link
Collaborator

alibuild commented Apr 2, 2024

Error while checking build/O2/fullCI for e02cd4e at 2024-04-02 19:22:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/12971-slc8_x86-64/0/Detectors/EMCAL/calibration/src/EMCALPedestalHelper.cxx:104:18: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

mfasDa
mfasDa previously approved these changes Apr 2, 2024
Copy link
Collaborator

@mfasDa mfasDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mfasDa mfasDa enabled auto-merge (squash) April 2, 2024 17:28
@mfasDa
Copy link
Collaborator

mfasDa commented Apr 2, 2024

CI errors unrelated

@shahor02
Copy link
Collaborator

shahor02 commented Apr 2, 2024

@mfasDa , it is : /sw/SOURCES/O2/12971-slc8_x86-64/0/Detectors/EMCAL/calibration/src/EMCALPedestalHelper.cxx:104:18: error: statement should be inside braces [readability-braces-around-statements]

- data to dcs ccdb has to be a vector<char>
- PedestalData is encoded as a string (in EMCALPedestalHelper)
@mfasDa mfasDa merged commit 4494b5b into AliceO2Group:dev Apr 3, 2024
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
…oup#12971)

- data to dcs ccdb has to be a vector<char>
- PedestalData is encoded as a string (in EMCALPedestalHelper)

Co-authored-by: jokonig <jokonig@cern.ch>
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
…oup#12971)

- data to dcs ccdb has to be a vector<char>
- PedestalData is encoded as a string (in EMCALPedestalHelper)

Co-authored-by: jokonig <jokonig@cern.ch>
mwinn2 pushed a commit to mwinn2/AliceO2 that referenced this pull request Apr 25, 2024
…oup#12971)

- data to dcs ccdb has to be a vector<char>
- PedestalData is encoded as a string (in EMCALPedestalHelper)

Co-authored-by: jokonig <jokonig@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants