Skip to content

[EMCAL-1116] Fix in mapping for pedestal calibration#12983

Merged
mfasDa merged 2 commits intoAliceO2Group:devfrom
jokonig:EMCAL-1116a
Apr 4, 2024
Merged

[EMCAL-1116] Fix in mapping for pedestal calibration#12983
mfasDa merged 2 commits intoAliceO2Group:devfrom
jokonig:EMCAL-1116a

Conversation

@jokonig
Copy link
Collaborator

@jokonig jokonig commented Apr 3, 2024

@jokonig jokonig requested a review from mfasDa as a code owner April 3, 2024 16:17
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

- For debugging purposes, the runnumber is added to the string stored in the ccdb
- Can be enabled with workflow argument --addRunNumber
- Off by default
@jokonig
Copy link
Collaborator Author

jokonig commented Apr 4, 2024

Added a second commit that allows to store the run number in the strong send to the test-ccdb in order for debugging as requested on https://its.cern.ch/jira/browse/EMCAL-1120

  • This option is off by default and can be enabled with the option --addRunNumber

Copy link
Collaborator

@mfasDa mfasDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mfasDa mfasDa enabled auto-merge (squash) April 4, 2024 11:58
@mfasDa mfasDa merged commit a54ee7f into AliceO2Group:dev Apr 4, 2024
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
)

* [EMCAL-1116] Fix in mapping for pedestal calibration

- As discussed on https://its.cern.ch/jira/browse/EMCAL-1120

* [EMCAL-1116] Add option to add runnumber to ccdb output string

- For debugging purposes, the runnumber is added to the string stored in the ccdb
- Can be enabled with workflow argument --addRunNumber
- Off by default

---------

Co-authored-by: jokonig <jokonig@cern.ch>
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
)

* [EMCAL-1116] Fix in mapping for pedestal calibration

- As discussed on https://its.cern.ch/jira/browse/EMCAL-1120

* [EMCAL-1116] Add option to add runnumber to ccdb output string

- For debugging purposes, the runnumber is added to the string stored in the ccdb
- Can be enabled with workflow argument --addRunNumber
- Off by default

---------

Co-authored-by: jokonig <jokonig@cern.ch>
mwinn2 pushed a commit to mwinn2/AliceO2 that referenced this pull request Apr 25, 2024
)

* [EMCAL-1116] Fix in mapping for pedestal calibration

- As discussed on https://its.cern.ch/jira/browse/EMCAL-1120

* [EMCAL-1116] Add option to add runnumber to ccdb output string

- For debugging purposes, the runnumber is added to the string stored in the ccdb
- Can be enabled with workflow argument --addRunNumber
- Off by default

---------

Co-authored-by: jokonig <jokonig@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants