DPL: Fix orderedCompletionPolicy getting stuck when oldestPossibleTimeslice message jumps by > 1 at once, and any but the last TF in the jump range is missing#13031
Merged
martenole merged 2 commits intoAliceO2Group:devfrom Apr 16, 2024
Conversation
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
…eslice message jumps by > 1 at once, and any but the last TF in the jump range is missing
7cea471 to
00983d4
Compare
martenole
approved these changes
Apr 16, 2024
Contributor
martenole
left a comment
There was a problem hiding this comment.
Thanks a lot! Shall I wait for the fullCI to finish and merge afterwards?
Collaborator
Author
|
Yes, you can merge once it is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix https://its.cern.ch/jira/browse/O2-4777
The problem is that when 2 oldestPossibleTimeframe updates are received together, they seem to be coalesced, so they can jump by 2 (or more).
If the first TF of these (or any TF in the jump range but the last) is missing, the consumeWhenOrdered completion policy needs an updated nextTimeFrame, to know that this TF is missing. This is done within the async queue. However, if the jump is > 1, the async queue runs only when the processing has reached the end of the jump range, which creates a deadlock if a TF in the jump range is not missing, since that would still need to be processed, which is blocked by the completion policy due to the lacking async queue update.
This PR splits the async queue task in two, and runs the decongestionService.nextTimeSlice update earlier, already when the currently agreed
oldestPossibleOutput.timeslice.valuetimeslice has been reached, unlocking the completionPolicy.