Skip to content

Conversation

@nstrangm
Copy link
Collaborator

  • GetCellIndex as first function to be tested:
    • Check sm number, module number, phi and eta index for all valid cells
    • Check two exceptions for invalid cells
    • Check against on-the-fly calculation in the testGeometry.cxx file itself
  • Minor correction in Geometry.cxx to improve readability of the code

- GetCellIndex as first function to be tested:
  - Check sm number, module number, phi and eta index for all valid cells
  - Check two exceptions for invalid cells
  - Check against on-the-fly calculation in the testGeometry.cxx file itself
- Minor correction in Geometry.cxx to improve readability of the code
@nstrangm nstrangm requested review from jokonig and mfasDa as code owners April 29, 2024 17:17
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2022-pp-apass6-2023-PbPb-apass2
async-2022-pp-apass4
async-2022-pp-apass4-accepted
async-2022-pp-apass6-2023-PbPb-apass2-accepted
async-2023-pbpb-apass3-accepted
async-2023-pbpb-apass4-accepted

Copy link
Collaborator

@mfasDa mfasDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mfasDa mfasDa enabled auto-merge (squash) April 30, 2024 08:05
@mfasDa mfasDa merged commit bac0ea0 into AliceO2Group:dev Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants