ITS: Add second iteration for the seeding vertexer #13306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mconcas
requested review from
arossi81,
f3sch,
fgrosa and
shahor02
as code owners
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
mconcas
force-pushed
the
its-second-vertexer-iteration
branch
5 times, most recently
from
95daea3 to
d8e439a
Compare
mconcas
force-pushed
the
its-second-vertexer-iteration
branch
from
d8e439a to
f4ec6a6
Compare
mconcas
changed the title
mconcas
force-pushed
the
its-second-vertexer-iteration
branch
from
8be9ac2 to
ff2dd46
Compare
Collaborator
Author
|
@shahor02 this should now be the best implementation so far. In the first comment of the PR there is the latest rationale of the PR. |
Collaborator
|
@mconcas thanks, I've reconstructed 1 chunk of LHC23zzh/544124 at 8kHz with the settings of
The increase of low mult. PVs look reasonable and at least there is no loss of K0 (though I don't see an increase either).
Unless you protest, I'll squash/merge it as soon as it passes fullCI, then we can have a central test on the grid which UPC people can analyse. |
shahor02
added
the
async-2023-pbpb-apass4
alcaliva
pushed a commit
that referenced
this pull request
Jul 26, 2024
* Add iteration structure * Overrule size of vector param with specific config value, for pp/PbPb * Propagate CKVals only to the first iteration * Add UPC vertices to the output * MC: assign a single flag to each vertex + purity * Improve logging * Tag vertices with iteration * Add DeltaROF skipping to the tracker * Add in-iteration deltaRof filtering * Add 4th iteration for UPCs * Skip second iteration vertices in first three iterations of the tracking (cherry picked from commit 710d1c8)
alcaliva
pushed a commit
that referenced
this pull request
Jul 26, 2024
* Add iteration structure * Overrule size of vector param with specific config value, for pp/PbPb * Propagate CKVals only to the first iteration * Add UPC vertices to the output * MC: assign a single flag to each vertex + purity * Improve logging * Tag vertices with iteration * Add DeltaROF skipping to the tracker * Add in-iteration deltaRof filtering * Add 4th iteration for UPCs * Skip second iteration vertices in first three iterations of the tracking (cherry picked from commit 710d1c8)
alcaliva
pushed a commit
that referenced
this pull request
Jul 28, 2024
* Add iteration structure * Overrule size of vector param with specific config value, for pp/PbPb * Propagate CKVals only to the first iteration * Add UPC vertices to the output * MC: assign a single flag to each vertex + purity * Improve logging * Tag vertices with iteration * Add DeltaROF skipping to the tracker * Add in-iteration deltaRof filtering * Add 4th iteration for UPCs * Skip second iteration vertices in first three iterations of the tracking (cherry picked from commit 710d1c8)
alcaliva
removed
the
async-2023-pbpb-apass4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ITSVertexerParam.nIterations=2: performs the second iteration for the vertexer with hard-coded UPC configurations.ITSCATrackerParam.doUPCIteration=true: performs a 4th iteration on the ROFs tagged by containing tagged vertices.EDIT:
The tracking completely ignores UPC vertices in its first three iterations but will not ignore any ROF (so that clusters can be considered also from ones that are without a vertex or do have an UPC).
Conversely, the fourth iteration will ignore all the rofs that do not contain a UPC vertex.
This will maintain consistency when comparing "hadronic" reconstruction with and without UPC settings.