Skip to content

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented Jul 28, 2024

In #13069 these were mistakenly removed and changes are now reverted.

In #13069 these were mistakenly removed and changes are now reverted.
@f3sch f3sch requested a review from shahor02 as a code owner July 28, 2024 08:06
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@chiarazampolli
Copy link
Collaborator

Hello @ktf ,

Can you merge? I cannot in O2.

Chiara

@chiarazampolli chiarazampolli added the async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 label Jul 28, 2024
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 43d9fc9 at 2024-07-28 12:25:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'

Full log here.

@mconcas mconcas merged commit 175e6ac into dev Jul 29, 2024
@mconcas mconcas deleted the glo/cmake_revert branch July 29, 2024 06:25
alcaliva pushed a commit that referenced this pull request Jul 29, 2024
In #13069 these were mistakenly removed and changes are now reverted.

(cherry picked from commit 175e6ac)
@alcaliva alcaliva removed the async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants