Skip to content

DPL: Silence another oldestPossible warning after STOP #13481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidrohr merged 2 commits into from
Sep 17, 2024
Merged

DPL: Silence another oldestPossible warning after STOP #13481

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a9521f
DPL: Silence another oldestPossible warning after STOP
davidrohr Sep 4, 2024
50c3867
Update Framework/Core/src/CommonServices.cxx
ktf Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions Framework/Core/src/CommonServices.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,12 @@ o2::framework::ServiceSpec CommonServices::decongestionSpec()
decongestion->nextTimeslice = std::max(decongestion->nextTimeslice, (int64_t)oldestPossibleOutput.timeslice.value);
O2_SIGNPOST_EVENT_EMIT(data_processor_context, cid, "oldest_possible_timeslice", "Next timeslice %" PRIi64, decongestion->nextTimeslice);
if (oldNextTimeslice != decongestion->nextTimeslice) {
O2_SIGNPOST_EVENT_EMIT_ERROR(data_processor_context, cid, "oldest_possible_timeslice", "Some Lifetime::Timeframe data got dropped starting at %" PRIi64, oldNextTimeslice);
auto& state = ctx.services().get<DeviceState>();
if (state.transitionHandling != TransitionHandlingState::NoTransition && DefaultsHelpers::onlineDeploymentMode()) {
O2_SIGNPOST_EVENT_EMIT_WARN(data_processor_context, cid, "oldest_possible_timeslice", "Stop transition requested. Some Lifetime::Timeframe data got dropped starting at %" PRIi64, oldNextTimeslice);
} else {
O2_SIGNPOST_EVENT_EMIT_ERROR(data_processor_context, cid, "oldest_possible_timeslice", "Some Lifetime::Timeframe data got dropped starting at %" PRIi64, oldNextTimeslice);
}
timesliceIndex.rescan();
}
}
Expand Down Expand Up @@ -644,8 +649,9 @@ o2::framework::ServiceSpec CommonServices::decongestionSpec()
oldestPossibleOutput.timeslice.value, decongestion.lastTimeslice);
return;
}
auto &queue = services.get<AsyncQueue>();
auto& spec = services.get<DeviceSpec const>();
auto& queue = services.get<AsyncQueue>();
const auto& spec = services.get<DeviceSpec const>();
const auto& state = services.get<DeviceState>();
auto *device = services.get<RawDeviceService>().device();
/// We use the oldest possible timeslice to debounce, so that only the latest one
/// at the end of one iteration is sent.
Expand Down Expand Up @@ -683,16 +689,20 @@ o2::framework::ServiceSpec CommonServices::decongestionSpec()
TimesliceId{oldestPossibleTimeslice}, -1);
if (decongestion.orderedCompletionPolicyActive) {
AsyncQueueHelpers::post(
queue, decongestion.oldestPossibleTimesliceTask, [ref = services, oldestPossibleOutput, &decongestion, &proxy, &spec, device, &timesliceIndex](size_t id) {
queue, decongestion.oldestPossibleTimesliceTask, [ref = services, oldestPossibleOutput, &decongestion, &proxy, &spec, &state, device, &timesliceIndex](size_t id) {
O2_SIGNPOST_ID_GENERATE(cid, async_queue);
int64_t oldNextTimeslice = decongestion.nextTimeslice;
decongestion.nextTimeslice = std::max(decongestion.nextTimeslice, (int64_t)oldestPossibleOutput.timeslice.value);
if (oldNextTimeslice != decongestion.nextTimeslice) {
O2_SIGNPOST_EVENT_EMIT_ERROR(async_queue, cid, "oldest_possible_timeslice", "Some Lifetime::Timeframe data got dropped starting at %" PRIi64, oldNextTimeslice);
if (state.transitionHandling != TransitionHandlingState::NoTransition && DefaultsHelpers::onlineDeploymentMode()) {
O2_SIGNPOST_EVENT_EMIT_WARN(async_queue, cid, "oldest_possible_timeslice", "Stop transition requested. Some Lifetime::Timeframe data got dropped starting at %" PRIi64, oldNextTimeslice);
} else {
O2_SIGNPOST_EVENT_EMIT_ERROR(async_queue, cid, "oldest_possible_timeslice", "Some Lifetime::Timeframe data got dropped starting at %" PRIi64, oldNextTimeslice);
}
timesliceIndex.rescan();
}
},
TimesliceId{oldestPossibleOutput.timeslice.value}, -1);
},
TimesliceId{oldestPossibleOutput.timeslice.value}, -1);
} },
.kind = ServiceKind::Serial};
}
Expand Down