Skip to content

TPC: Multiple fixes and extensions #13533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shahor02 merged 7 commits into from
Sep 23, 2024
Merged

TPC: Multiple fixes and extensions #13533

shahor02 merged 7 commits into from
Sep 23, 2024

Conversation

@wiechula
Copy link
Collaborator

@wiechula wiechula commented Sep 20, 2024

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@alibuild
Copy link
Collaborator

alibuild commented Sep 20, 2024 •
edited
Loading

Error while checking build/O2/fullCI for 017c757 at 2024-09-22 23:20:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
command /sw/slc8_x86-64/O2/13533-slc8_x86-64-local1/prodtests/full-system-test/dpl-workflow.sh had nonzero exit code 137
[67456:tpc-vd-tgl-calib]: [ERROR] error parsing options of o2-tpc-vdrift-tgl-calibration-workflow: option '--time-slot-seconds' is ambiguous and matches different versions of '--time-slot-seconds'
[ERROR] Workflow crashed - PID 67456 (tpc-vd-tgl-calib) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 67458 (ft0-merge-integrated-clusters) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67482 (trd-trackbased-calib) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67599 (Dispatcher) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67686 (qc-task-PHS-ClusterTask) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67663 (qc-task-ITS-ITSTrackTask) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67439 (qc-task-MFT-MFTAsyncTask) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67460 (tof-merge-integrated-clusters) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67579 (qc-task-TRD-PHTrackMatch) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67473 (rct-updater) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67908 (TPC-Clusters-proxy) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67452 (mch-time-cluster-finder) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67879 (FDD-DigitQcTaskFDD-proxy) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67880 (FT0-DigitQcTaskFT0-proxy) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67622 (muon-track-matcher) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67443 (tpc-calibrator-dEdx) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67481 (qc-task-TRD-Tracking) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67667 (qc-task-MCH-QcTaskMCHDigits) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67606 (mch-error-merger) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67457 (ctf-writer) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67580 (mch-cluster-transformer) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67914 (TRD-Tracklets-proxy) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67450 (ft0-integrate-clusters) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67605 (mean-vertex-calibration) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67897 (MID-QcTaskMIDClust-proxy) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67743 (qc-task-ZDC-QcZDCRecTask) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67435 (ft0-time-offset-calib) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67447 (tpc-calibrator-gainmap-tracks) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67656 (qc-task-GLO-MTCITSTPC) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67693 (qc-task-TOF-TaskDigits) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67565 (primary-vertexing) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67624 (qc-task-EMC-CellTask) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67865 (TRD-PHTrackMatch-proxy) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67604 (mch-track-finder) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67642 (qc-task-FDD-DigitQcTaskFDD) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67658 (qc-task-GLO-Vertexing) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67659 (qc-task-ITS-ITSClusterTask) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67714 (qc-task-TPC-Clusters) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67905 (TOF-MatchingTOFwTRD-proxy) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67925 (ZDC-QcZDCRecTask-proxy) was killed abnormally with Killed and exited code was set to 137.
[ERROR] Workflow crashed - PID 67454 (MIDTracker) was killed abnormally with Killed and exited code was set to 137.
[0 more errors; see full log]

Full log here.

@wiechula
Copy link
Collaborator Author

wiechula commented Sep 20, 2024

It seems the error is not related to this PR, could someone please have a look?

shahor02
shahor02 requested changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wiechula
the fullCI failure is genuine, see below.

@wiechula
fix completion policy
929c1b2
@wiechula
Add possibility for a common file name extension saving canvases
da562ca
@wiechula
Extend FW parameter file creation
a01122b 
* Allow for different thresholds for each ROC Type in pedestal file
  creation
* Add common mode k-values in float precision and inverse k-factors with
  truncated precision
@wiechula
Digit class extension for simple drawing
225dda1
@wiechula
Extend TPC refitter
499f714 
* possibility to dump ITS-TPC
* Tsallis downsampling
* MB sampling
* shared flag added to native clusters
* Charge info now via native clusters
* Write full native clusters
* add occupancy info
* add cosmics refitting with TOF cluster time
@wiechula
Extend time gain calibration
87ec8bb 
* Undo previous timeGain corrections to allow for residual calibration
* slot length in seconds
* slot extension for CCDB (for residual calibration)
* simple looper cut
* settable debug output name
* dumping of calibration histograms per slot
* debug output on track level
* average entries for calibration
@wiechula
Update event display
cdc27e0 
- Pad vs time view for a single row
  * visualisation of hovered time bin in ADC vs. time
- cluster overlay in pad vs. time view
  * selection of cluster flags
- Pad vs. row view for a single time bin
  * visualisation of hovered time bin in ADC vs. time
@wiechula
Copy link
Collaborator Author

wiechula commented Sep 23, 2024

Thanks for checking @shahor02 , can this be merged now?

@shahor02 shahor02 enabled auto-merge (rebase) September 23, 2024 13:48
@shahor02 shahor02 disabled auto-merge September 23, 2024 13:48
@shahor02 shahor02 merged commit eaa7fbb into AliceO2Group:dev Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahor02 shahor02 shahor02 requested changes

@davidrohr davidrohr Awaiting requested review from davidrohr davidrohr is a code owner

@sawenzel sawenzel Awaiting requested review from sawenzel sawenzel is a code owner

@benedikt-voelkel benedikt-voelkel Awaiting requested review from benedikt-voelkel

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wiechula @alibuild @shahor02