Added alien path compatibility, Phi rotation and event pool randomisation to GenO2Kine#13571
Merged
sawenzel merged 22 commits intoAliceO2Group:devfrom Oct 31, 2024
Merged
Added alien path compatibility, Phi rotation and event pool randomisation to GenO2Kine#13571sawenzel merged 22 commits intoAliceO2Group:devfrom
sawenzel merged 22 commits intoAliceO2Group:devfrom
Conversation
jackal1-66
requested review from
a team,
benedikt-voelkel and
sawenzel
as code owners
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Collaborator
Author
|
This PR is strictly connected to AliceO2Group/O2DPG#1760 |
sawenzel
reviewed
Oct 10, 2024
…rations At the moment the generation is random, but it's the starting point for event injection with external Kinematic files. The system has been tested locally and it seems to be working fine.
sawenzel
reviewed
Oct 29, 2024
Collaborator
|
Can you also change the title of the PR and remove the WIP? |
jackal1-66
changed the title
…)" This reverts commit 6a2cc7e.
Collaborator
Author
|
There's a bit of a mess with the commits. Please DO NOT MERGE until I've sorted them out. |
)" This reverts commit 335f4c9.
Collaborator
Author
|
Problem fixed. The merging can go forward. |
sawenzel
reviewed
Oct 30, 2024
sawenzel
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to the ticket https://its.cern.ch/jira/browse/O2-5216
It has been tested locally and the feature works as expected.
Check the ticket for more information.