Skip to content

Conversation

@ddobrigk
Copy link
Contributor

@aalkin @ktf I believe this extra equivalency declaration is needed to make a trick of the strangeness builders work. In the trick, I subscribe only to TracksExtra and I de-reference an index to tracks directly to TracksExtra so that I avoid declaring separate process functions for Tracks and TracksIU - with the versioning of TracksExtra to 002, the trick was unfortunately broken, and I think an equivalency of A-B and another of B-C doesn't mean, in the framework, that A-C is made equivalent. Can you please check and merge if you agree? Thank you!

@ddobrigk ddobrigk requested a review from a team as a code owner December 13, 2024 11:04
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@aalkin
Copy link
Member

aalkin commented Dec 13, 2024

@ddobrigk you are right, currently the equivalence is not transitive. However, with the new mechanism behind the tables, I will later make it so anything with the same description is considered equivalent, so these declarations will not be needed anymore.

@ktf ktf merged commit 3318e86 into AliceO2Group:dev Dec 13, 2024
11 of 13 checks passed
@ddobrigk ddobrigk deleted the fixequiv branch December 13, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants