Fixing handling of edge clusters - DON'T MERGE #14020
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Ping @davidrohr |
Please consider the following formatting changes to AliceO2Group#14020
| bool correct = (leftEdge) ? (pad < mPadMean) : (pad > mPadMean); | ||
| if (leftEdge && pad == 1) { // only check charge at boundary if maximum is at least one pad away from boundary | ||
| correct = correct && (padBoundaryCharges[0] > 0); // Only correct if cluster is asymmetric with charge > 0 towards sector boundary, otherwise all charge is found | ||
| } else if (!leftEdge && pad == (geo.NPads(pos.row()) - 1)) { |
There was a problem hiding this comment.
Should't this be
} else if (!leftEdge && pad == (geo.NPads(pos.row()) - 2)) {
correct = correct && (padBoundaryCharges[geo.NPads(pos.row()) - 1] > 0);
?
There was a problem hiding this comment.
OK, I misunderstood the definition of padBoundatyCharges...
In any case, I think it should be pad == (geo.NPads(pos.row()) - 2 and not -1.
For the padBoundaryCharge, ok, that looks correct, but did you double-check it access the correct value, just to be sure?
| ChargePos pos = filteredPeakPositions[CAMath::Min(idx, clusternum - 1)]; | ||
| Charge charge = chargeMap[pos].unpack(); | ||
|
|
||
| Charge padBoundaryCharges[2] = {chargeMap[pos.delta({-1, 0})].unpack(), chargeMap[pos.delta({1, 0})].unpack()}; |
There was a problem hiding this comment.
Can't you define this further down, where it is actually used?
There was a problem hiding this comment.
Where excatly? Directly above pc.finalize?
| bool correct = (leftEdge) ? (pad < mPadMean) : (pad > mPadMean); | ||
| if (leftEdge && pad == 1) { // only check charge at boundary if maximum is at least one pad away from boundary | ||
| correct = correct && (padBoundaryCharges[0] > 0); // Only correct if cluster is asymmetric with charge > 0 towards sector boundary, otherwise all charge is found | ||
| } else if (!leftEdge && pad == (geo.NPads(pos.row()) - 1)) { |
There was a problem hiding this comment.
OK, I misunderstood the definition of padBoundatyCharges...
In any case, I think it should be pad == (geo.NPads(pos.row()) - 2 and not -1.
For the padBoundaryCharge, ok, that looks correct, but did you double-check it access the correct value, just to be sure?
|
No I didn't check it further. I'll compile and run it and let you know |
davidrohr
changed the title
3 participants
No description provided.