Skip to content

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented May 21, 2025

No description provided.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

davidrohr
davidrohr previously approved these changes May 22, 2025
Copy link
Collaborator

@davidrohr davidrohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK from my side, but I would ask you to check that is has no performance / stability regression when running on the EPN GPUs.

@mconcas
Copy link
Collaborator

mconcas commented May 22, 2025

Hello @f3sch,

The TimeFrame templatization is something nice that we are eventually needing for the future, thanks for taking care of this.
Also code cleanup is something that is very welcome, as it removes stratifications of code.
I see also some improved syntaxes here and there that are most welcome as well.

As the general usual comment, there is a lot of changes in a lot of files both CPU/GPU. Surely for the templatization this is unavoidable, but it would be better to have the two streams of changing somehow separated in many PRs.
This would facilitate reviews and collaborations from other people (e.g. I have some developments ongoing on the GPU vertexer and I'd rather not have to deal with conflicts caused by refactoring included in a PR supposedly targeting a development).

@f3sch
Copy link
Collaborator Author

f3sch commented May 25, 2025

I checked that after the templatization the performance remains (within stat. error the same):
trk_tasks_comparison

@f3sch f3sch marked this pull request as ready for review May 25, 2025 18:03
@mconcas
Copy link
Collaborator

mconcas commented May 27, 2025

@fprino this change is essentially an upgrade in the compatibility for trackers with more than 7 layers (e.g. ALICE 3).
It is also a required base for implementing a better protection against memory spike, which @f3sch is preparing in #14326.
There should be no functional change in the algorithms in this PR.
Upon your approval I'm merging.

@mconcas mconcas merged commit 359e28b into AliceO2Group:dev May 27, 2025
14 checks passed
@f3sch f3sch deleted the its/gpu_pr1 branch May 27, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants