Skip to content

DPL: use new indices methods to navigate through InputRecord in output-proxy#15270

Merged
ehellbar merged 1 commit intoAliceO2Group:devfrom
ehellbar:pr15270
Apr 11, 2026
Merged

DPL: use new indices methods to navigate through InputRecord in output-proxy#15270
ehellbar merged 1 commit intoAliceO2Group:devfrom
ehellbar:pr15270

Conversation

@ehellbar
Copy link
Copy Markdown
Collaborator

@ehellbar ehellbar commented Apr 10, 2026

No description provided.

@ehellbar ehellbar requested a review from a team as a code owner April 10, 2026 14:43
@ehellbar
Copy link
Copy Markdown
Collaborator Author

@ktf here I don't know what the intention of the loop and looping direction was in the first place, so I tried to keep it like that using the new methods you implemented when you refactored the InputRecord.

the old loop and methods were simply way to slow after we went away from the MessageSet, it was simply hidden before by the issues and slow-down we had in the QC task in front.

I might also check the code if there are other places (e.g. detector code) which look suspicious.

@ehellbar
Copy link
Copy Markdown
Collaborator Author

also, if there is a more elegant way to do this that I don't see right now, please let me know :)

@ktf
Copy link
Copy Markdown
Member

ktf commented Apr 10, 2026

This is to solve a performance regression in the proxy, correct? LGTM for now.

@ehellbar
Copy link
Copy Markdown
Collaborator Author

ehellbar commented Apr 10, 2026

yes, the regression is in the dpl-output-proxy. Thank you for reviewing it.

@ehellbar ehellbar merged commit 97a77d9 into AliceO2Group:dev Apr 11, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants