DPL: boost::property_tree::json_parser::write_json no longer adds EoL#15333
Merged
ktf merged 1 commit intoAliceO2Group:devfrom Apr 27, 2026
Merged
DPL: boost::property_tree::json_parser::write_json no longer adds EoL#15333ktf merged 1 commit intoAliceO2Group:devfrom
ktf merged 1 commit intoAliceO2Group:devfrom
Conversation
Member
|
https://github.com/boostorg/property_tree/pull/23/changes is the upstream change. How come this does not break everything? |
Member
Author
|
We only use this route to collect the configuration at the end of processing, otherwise we would have noticed it when bumping boost. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes malformed dpl-config.json at the end of processing, as the old code was removing the closing brace.