DPL: decouple DataAllocator from TableBuilder#2983
Merged
ktf merged 1 commit intoAliceO2Group:devfrom Feb 21, 2020
Merged
Conversation
Member
Author
|
@matthiasrichter this is our Holy Grail. It allows to expose arrow only to the tasks / workflows which use it. We could do something similar for ROOT and for boost, actually. |
ktf
force-pushed
the
decouple-table-builder
branch
from
b5bc5d6 to
ca8aa83
Compare
If one needs DataAllocator to create arrow tables, the TableBuilder.h header should be included before DataAllocator.h. This way we avoid rebuilding everything when ASoA.h changes. We should probably do the same for boost and ROOT.
ktf
force-pushed
the
decouple-table-builder
branch
from
ca8aa83 to
c179106
Compare
Collaborator
|
That looks great! I think that is good enough for the moment and allows to disentangle compilation. Actually, the sequence of including the headers should not matter, right? Only before the actual function call, the TableBuilder.h needs to be included. Lets clean up ROOT and BOOST support in a similar way (when we have time). |
Member
Author
|
Not sure if only before the actual function call or before the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one needs DataAllocator to create arrow tables, the
TableBuilder.h header should be included before DataAllocator.h.
This way we avoid rebuilding everything when ASoA.h changes.
We should probably do the same for boost and ROOT.