TRD Digitizer: moving temporary variables to class members#3389
Merged
Conversation
jolopezl
changed the title
bazinski
reviewed
Apr 27, 2020
bazinski
reviewed
Apr 27, 2020
sawenzel
reviewed
Apr 28, 2020
sawenzel
reviewed
Apr 29, 2020
Contributor
Author
|
@sawenzel, current issues in build/o2checkcode/o2 look unrelated to this pull request. |
sawenzel
reviewed
Apr 30, 2020
sawenzel
approved these changes
Apr 30, 2020
amorsch
pushed a commit
to amorsch/AliceO2
that referenced
this pull request
May 28, 2020
…oup#3389) * moving variables to class members for speedup * removed unused variables * changed method name to setSimulationParameters * redefined the number of timebins for clarity and changed if/log(debug) for an assert * additional naming convention changes * making static constexpr some variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two minor improvements were spotted while developing the pileup implementation for the TRD digitizer:
I prefer to make this small PR now and do not mix this with the pileup implementation.
In 10 pp events:
(Now)
TRD: Digitization took 0.949013s(Before)
TRD: Digitization took 1.11397sIn 1 hi event:
(Now)
TRD: Digitization took 124.626s(Before)
TRD: Digitization took 136.157s