Protection against out of bound access in CTF dictionaries#4123
Closed
shahor02 wants to merge 1 commit into
Closed
Protection against out of bound access in CTF dictionaries#4123shahor02 wants to merge 1 commit into
shahor02 wants to merge 1 commit into
Conversation
Collaborator
|
Thx, with this fix the TPC encoding has become stable. Looks good, and CPU consumption is down as well. |
shahor02
changed the title
Collaborator
Author
|
hm, it should not have affected CPU consumption. Do you mean wrt not using external dictionaries? |
Collaborator
|
Yes, CPU consumption is down wrt. no external dictionaries at all. This PR doesn't change CPU consumption, it just fixed the crash. |
Collaborator
|
#4125 should not only fix this issue but also improve performance and memory consumption quite nicely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.