[MCH] allow sending full HBframes in MCH custom raw page reader#4286
[MCH] allow sending full HBframes in MCH custom raw page reader#4286aphecetche merged 2 commits intoAliceO2Group:devfrom
Conversation
This commit adds an option to the MCH CRU page reader that allows to buffer the pages belonging to the same orbit and send them in one single DPL message. The default behavior is to send each CRU page in a separate DPL message.
aphecetche
left a comment
aphecetche
left a comment
There was a problem hiding this comment.
Just want to note that the run function is getting a bit long and not trivial to read (the printouts does not help, for instance). Might consider some refactoring at some point...
It is true that the code is not very "linear", but I expect this custom page reader to disappear in the near future. It is currently used mainly to process data that might have issues with the HBframe ordering/formatting, and hence might screw up the STFbuilder. Hence I would propose to leave it as it is for the moment, and do some further work on it in case we will decide to keep it around longer... |
|
@aphecetche I had to force a rebuild because some jobs failed for reasons unrelated to this PR... could you review it again? Thanks! |
2 participants
This commit adds an option to the MCH CRU page reader that allows to buffer the pages belonging to the same orbit and send them in one single DPL message.
The default behavior is to send each CRU page in a separate DPL message.