Skip to content

Conversation

@aalkin
Copy link
Member

@aalkin aalkin commented Sep 11, 2020

  • Index columns will now be bound not only to the origin type they were declared with, but also to any compatible (i.e. containing same columns) table type. In data model all indices should refer to the "smallest" origin table type with least columns, to make them more generic.
  • Default index getter still uses the declared binding, to get correct binding one needs to use templated version:
using myCol = soa::Join<aod::Collisions, aod::CollisionsExtra>;
auto id = track0.collision_as<myCol>().globalIndex();

@aalkin aalkin requested review from a team and jgrosseo as code owners September 11, 2020 09:28
Copy link
Member

@ktf ktf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Should we squash?

@aalkin
Copy link
Member Author

aalkin commented Sep 11, 2020

@ktf yes please, thank you.

@ktf ktf merged commit 7c508b6 into AliceO2Group:dev Sep 11, 2020
@aalkin aalkin deleted the index-replace branch September 24, 2020 11:20
arakotoz pushed a commit to arakotoz/AliceO2 that referenced this pull request Sep 26, 2020
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants