Skip to content

DPL Analysis: table slicing helper#4999

Merged
ktf merged 2 commits intoAliceO2Group:devfrom
aalkin:slicing-helper
Dec 5, 2020
Merged

DPL Analysis: table slicing helper#4999
ktf merged 2 commits intoAliceO2Group:devfrom
aalkin:slicing-helper

Conversation

@aalkin
Copy link
Member

@aalkin aalkin commented Dec 4, 2020

@jgrosseo this should be faster than filtering for inner loop, but will only work with sorted index like the grouping.

@aalkin aalkin requested review from a team, iarsene and jgrosseo as code owners December 4, 2020 10:21
jgrosseo
jgrosseo previously approved these changes Dec 4, 2020
@ktf
Copy link
Member

ktf commented Dec 4, 2020

@awegrzyn there is an exception being thrown now in monitoring. Could it be that you require ApMon in the tests even if not there? Could you please check?

@awegrzyn
Copy link
Contributor

awegrzyn commented Dec 4, 2020

It should not be the case as in o2-dataflow defaults we disabled ApMon long time ago, but lemme take a look.

@ktf ktf merged commit 2be0482 into AliceO2Group:dev Dec 5, 2020
@aalkin aalkin deleted the slicing-helper branch December 16, 2020 09:19
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants