PWGHF: first checked implementation of Xic->pKpi filtering by mfaggin · Pull Request #5436 · AliceO2Group/AliceO2

mfaggin · 2021-02-10T14:57:34Z

No description provided.

mfaggin · 2021-02-10T15:44:47Z

Linked PR in validation framework: AliceO2Group/Run3AnalysisValidation#158

mfaggin · 2021-02-12T13:35:26Z

@ginnocen @vkucera @DelloStritto few required fixes implemented

mfaggin · 2021-02-16T09:23:09Z

@ginnocen switched to "ready for review" status

vkucera · 2021-02-18T11:44:24Z

@mfaggin @DelloStritto @ginnocen If I understand correctly, the only difference between the Lc and Xic selector should eventually be the configuration (including the mass cut) and the output flag column.
Why don't we try to reuse as many functions as possible from the existing Lc selector?

mfaggin · 2021-02-18T11:51:00Z

@mfaggin @DelloStritto @ginnocen If I understand correctly, the only difference between the Lc and Xic selector should eventually be the configuration (including the mass cut) and the output flag column.
Why don't we try to reuse as many functions as possible from the existing Lc selector?

IMHO, this should be avoided at this stage. My implementation of the Xic is indeed based on the Lc task, since we are talking about particles that are reconstructed in the same decay channel. However, being two different particles with different kinematics, I would not force them to be equal or strongly correlated for the moment, because for real analysis things may differentiate. I agre with you for methods like the one on the pKpi invariant mass calculations, but not for all methods.

vkucera · 2021-02-18T12:13:15Z

@mfaggin Is there any topological cut that could ever be applied only for Lc and not for Xic?

mfaggin · 2021-02-18T13:04:49Z

@vkucera at this stage I do not see indeed, but I do not have such a long-time view to confirm it at 100%. I can try to have a look if such an operation would be too constraining or not, but I do not have too much time to dedicate on this business in a short time-scale. Do you think it's crucial for this PR to be approved? I may think to address this topic after this PR merging, so that something is already in place for Xic.

mfaggin · 2021-02-22T09:44:36Z

Hi @vkucera , I see conflicts in Analysis/Tasks/PWGHF/CMakeLists.txt that probably depend on the fact that in the meanwhile something changed in the dev branch (also for the validation framework). I think it's better if you fix it as you prefer, according to the new conventions, in both cases. Do you agree?

vkucera · 2021-02-22T18:10:02Z

Hi @vkucera , I see conflicts in Analysis/Tasks/PWGHF/CMakeLists.txt that probably depend on the fact that in the meanwhile something changed in the dev branch (also for the validation framework). I think it's better if you fix it as you prefer, according to the new conventions, in both cases. Do you agree?

Hi @mfaggin , those should be just conflicts due to the addition of the MC validation task. You should just rebase, resolve the conflicts and push again.

mfaggin · 2021-02-23T10:05:36Z

Hi @vkucera , I see conflicts in Analysis/Tasks/PWGHF/CMakeLists.txt that probably depend on the fact that in the meanwhile something changed in the dev branch (also for the validation framework). I think it's better if you fix it as you prefer, according to the new conventions, in both cases. Do you agree?

Hi @mfaggin , those should be just conflicts due to the addition of the MC validation task. You should just rebase, resolve the conflicts and push again.

Hi @vkucera , I manually resolved the conflicts directly from the git interface, please check if my implementations are ok.

vkucera

As discussed, the selector should use functions from the Lc selector, but that can be done in the next steps.

- (HFCandidateCreator3Prong.cxx) remove refuse std::move, forgot in the middle of the for loop - (HFCandidateCreator3Prong.cxx) fix if statement condition for isMatchedMCGen - (taskXic.cxx) fix MC histogram titles

…isMatchedMCGen for Xic->pKpi

vkucera · 2021-03-01T21:01:26Z

The code looks fine now.
Just the variable names need to be fixed to comply with the conventions.

mfaggin · 2021-03-02T07:39:31Z

The code looks fine now.
Just the variable names need to be fixed to comply with the conventions.

Hi @vkucera , which variables are you referring to? If I am not wrong, the variable names in the HFXicToPKPiCandidateSelector.cxx are equal to the ones in HFLcToPKPiCandidateSelector.cxx, but I am not sure if you are referring to them.

vkucera · 2021-03-02T16:25:59Z

The code looks fine now.
Just the variable names need to be fixed to comply with the conventions.

Hi @vkucera , which variables are you referring to? If I am not wrong, the variable names in the HFXicToPKPiCandidateSelector.cxx are equal to the ones in HFLcToPKPiCandidateSelector.cxx, but I am not sure if you are referring to them.

I meant the configurables and histograms, but it's fine, we can rename them later, together with everything else.

vkucera

@ginnocen Good from my side.

mfaggin · 2021-03-04T16:06:01Z

@vkucera I followed your instructions and the adaptAnalysisTask and charge() changes should be correctly in place.

vkucera · 2021-03-07T12:45:24Z

label -> mcParticle

@vkucera the change is in place

vkucera

@ginnocen

ginnocen · 2021-03-08T14:38:45Z

hi @mfaggin @vkucera. I added a couple of very minor comments. We will need to improve the selector, as you know :). Once those two little details are solved I think it is ready to go. Thanks to both for the nice work.

jgrosseo · 2021-03-10T07:21:07Z

Mac CI pending since 2 days. Merging.

…oup#5436) * PWGHF: first checked code of Xic->pKpi filtering * Update HFSecondaryVertex.h * Update HFXicCandidateSelector.cxx * Fix code with camelCase syntax conventions * Fix code syntax conventions for Xic methods * PWGHF: further fixes for Xic to pKpi filtering and analysis - (HFCandidateCreator3Prong.cxx) remove refuse std::move, forgot in the middle of the for loop - (HFCandidateCreator3Prong.cxx) fix if statement condition for isMatchedMCGen - (taskXic.cxx) fix MC histogram titles * PWGHF: avoid storing return values of RecoDecay::getMatchedMCRec and isMatchedMCGen for Xic->pKpi * PWGHF: pair Xic code with adaptAnalysisTask and charge() changes * PWGHF: remove check for charge to be different from 0 * PWGHF: change label_as into mcParticle_as in taskXic * PWGHF: fix particle label for ct distribution in taskXic * PWGHF: remove selection flag for Xicbar (obsolete) from taskXic Co-authored-by: Mattia Faggin <mfaggin@cern.ch>

mfaggin force-pushed the mfaggin_XicTopKpi branch from 6e806a2 to 7b95b03 Compare February 12, 2021 13:20

PWGHF: first checked code of Xic->pKpi filtering

652a5b5

mfaggin force-pushed the mfaggin_XicTopKpi branch from 7b95b03 to 652a5b5 Compare February 12, 2021 13:29

Merge branch 'dev' into mfaggin_XicTopKpi

059e0fb

mfaggin marked this pull request as ready for review February 16, 2021 09:22

mfaggin requested review from ginnocen, iarsene and jgrosseo as code owners February 16, 2021 09:22

vkucera requested changes Feb 17, 2021

View reviewed changes

Comment thread Analysis/DataModel/include/AnalysisDataModel/HFSecondaryVertex.h

Update HFSecondaryVertex.h

4958e94

DelloStritto reviewed Feb 18, 2021

View reviewed changes

Comment thread Analysis/Tasks/PWGHF/HFXicCandidateSelector.cxx Outdated

Update HFXicCandidateSelector.cxx

c6b74a8

vkucera reviewed Feb 18, 2021

View reviewed changes

Comment thread Analysis/DataModel/include/AnalysisDataModel/HFCandidateSelectionTables.h Outdated

Fix code with camelCase syntax conventions

d516858

Fix code syntax conventions for Xic methods

38af94a

vkucera requested changes Feb 26, 2021

View reviewed changes

Comment thread Analysis/Tasks/PWGHF/HFCandidateCreator3Prong.cxx Outdated

Comment thread Analysis/Tasks/PWGHF/HFCandidateCreator3Prong.cxx Outdated

Comment thread Analysis/Tasks/PWGHF/HFXicToPKPiCandidateSelector.cxx Outdated

Comment thread Analysis/Tasks/PWGHF/taskXic.cxx Outdated

PWGHF: further fixes for Xic to pKpi filtering and analysis

d79b31b

- (HFCandidateCreator3Prong.cxx) remove refuse std::move, forgot in the middle of the for loop - (HFCandidateCreator3Prong.cxx) fix if statement condition for isMatchedMCGen - (taskXic.cxx) fix MC histogram titles

mfaggin force-pushed the mfaggin_XicTopKpi branch from 1b521b4 to d79b31b Compare March 1, 2021 08:11

vkucera requested changes Mar 1, 2021

View reviewed changes

Comment thread Analysis/Tasks/PWGHF/HFCandidateCreator3Prong.cxx Outdated

PWGHF: avoid storing return values of RecoDecay::getMatchedMCRec and …

f0e98b8

…isMatchedMCGen for Xic->pKpi

vkucera previously approved these changes Mar 2, 2021

View reviewed changes

PWGHF: pair Xic code with adaptAnalysisTask and charge() changes

0776b93

mfaggin dismissed vkucera’s stale review via 0776b93 March 4, 2021 16:02

mfaggin force-pushed the mfaggin_XicTopKpi branch from 387c213 to 0776b93 Compare March 4, 2021 16:02

vkucera requested changes Mar 4, 2021

View reviewed changes

Comment thread Analysis/Tasks/PWGHF/HFXicToPKPiCandidateSelector.cxx Outdated

PWGHF: remove check for charge to be different from 0

e20d36b

mfaggin force-pushed the mfaggin_XicTopKpi branch from 149f368 to e20d36b Compare March 5, 2021 08:34

vkucera requested changes Mar 7, 2021

View reviewed changes

PWGHF: change label_as into mcParticle_as in taskXic

afb4535

mfaggin force-pushed the mfaggin_XicTopKpi branch from 9d97ed8 to afb4535 Compare March 8, 2021 08:25

vkucera previously approved these changes Mar 8, 2021

View reviewed changes

ginnocen reviewed Mar 8, 2021

View reviewed changes

Comment thread Analysis/Tasks/PWGHF/taskXic.cxx Outdated

PWGHF: fix particle label for ct distribution in taskXic

c6c4228

mfaggin dismissed vkucera’s stale review via c6c4228 March 8, 2021 13:58

mfaggin force-pushed the mfaggin_XicTopKpi branch from b82e082 to c6c4228 Compare March 8, 2021 13:58

ginnocen reviewed Mar 8, 2021

View reviewed changes

Comment thread Analysis/Tasks/PWGHF/taskXic.cxx Outdated

PWGHF: remove selection flag for Xicbar (obsolete) from taskXic

a01c377

mfaggin force-pushed the mfaggin_XicTopKpi branch from 7b66c68 to a01c377 Compare March 8, 2021 15:26

Merge branch 'dev' into mfaggin_XicTopKpi

fc47eed

ginnocen self-requested a review March 8, 2021 15:39

ginnocen approved these changes Mar 8, 2021

View reviewed changes

jgrosseo merged commit 2f27fc3 into AliceO2Group:dev Mar 10, 2021

mfaggin deleted the mfaggin_XicTopKpi branch March 17, 2021 09:50

Conversation

mfaggin commented Feb 10, 2021

Uh oh!

mfaggin commented Feb 10, 2021

Uh oh!

mfaggin commented Feb 12, 2021

Uh oh!

mfaggin commented Feb 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vkucera commented Feb 18, 2021

Uh oh!

mfaggin commented Feb 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkucera commented Feb 18, 2021

Uh oh!

mfaggin commented Feb 18, 2021

Uh oh!

mfaggin commented Feb 22, 2021

Uh oh!

vkucera commented Feb 22, 2021

Uh oh!

mfaggin commented Feb 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkucera left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vkucera commented Mar 1, 2021

Uh oh!

mfaggin commented Mar 2, 2021

Uh oh!

vkucera commented Mar 2, 2021

Uh oh!

vkucera left a comment

Choose a reason for hiding this comment

Uh oh!

mfaggin commented Mar 4, 2021

Uh oh!

Uh oh!

vkucera Mar 7, 2021

Choose a reason for hiding this comment

Uh oh!

mfaggin Mar 8, 2021

Choose a reason for hiding this comment

Uh oh!

vkucera left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ginnocen commented Mar 8, 2021

Uh oh!

jgrosseo commented Mar 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

mfaggin commented Feb 16, 2021 •

edited

Loading

mfaggin commented Feb 18, 2021 •

edited

Loading

mfaggin commented Feb 23, 2021 •

edited

Loading